From: Michal Hocko <mhocko@kernel.org>
To: Honglei Wang <honglei.wang@oracle.com>
Cc: linux-mm@kvack.org, vdavydov.dev@gmail.com, hannes@cmpxchg.org
Subject: Re: [PATCH] mm/vmscan: get number of pages on the LRU list in memcgroup base on lru_zone_size
Date: Tue, 3 Sep 2019 11:28:27 +0200 [thread overview]
Message-ID: <20190903092827.GP14028@dhcp22.suse.cz> (raw)
In-Reply-To: <20190903085416.12059-1-honglei.wang@oracle.com>
On Tue 03-09-19 16:54:16, Honglei Wang wrote:
> lruvec_lru_size() is involving lruvec_page_state_local() to get the
> lru_size in the current code. It's base on lruvec_stat_local.count[]
> of mem_cgroup_per_node. This counter is updated in batch. It won't
> do charge if the number of coming pages doesn't meet the needs of
> MEMCG_CHARGE_BATCH who's defined as 32 now.
>
> This causes small section of memory can't be handled as expected in
> some scenario. For example, if we have only 32 pages madvise free
> memory in memcgroup, these pages won't be freed as expected when it
> meets memory pressure in this group.
Could you be more specific please?
> Getting lru_size base on lru_zone_size of mem_cgroup_per_node which
> is not updated in batch can make this a bit more accurate.
This is effectivelly reverting 1a61ab8038e72. There were no numbers
backing that commit, neither this one has. The only hot path I can see
is workingset_refault. All others seems to be in the reclaim path.
> Signed-off-by: Honglei Wang <honglei.wang@oracle.com>
That being said, I am not against this patch but the changelog should be
more specific about the particular problem and how serious it is.
> ---
> mm/vmscan.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index c77d1e3761a7..c28672460868 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -354,12 +354,13 @@ unsigned long zone_reclaimable_pages(struct zone *zone)
> */
> unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru, int zone_idx)
> {
> - unsigned long lru_size;
> + unsigned long lru_size = 0;
> int zid;
>
> - if (!mem_cgroup_disabled())
> - lru_size = lruvec_page_state_local(lruvec, NR_LRU_BASE + lru);
> - else
> + if (!mem_cgroup_disabled()) {
> + for (zid = 0; zid < MAX_NR_ZONES; zid++)
> + lru_size += mem_cgroup_get_zone_lru_size(lruvec, lru, zid);
> + } else
> lru_size = node_page_state(lruvec_pgdat(lruvec), NR_LRU_BASE + lru);
>
> for (zid = zone_idx + 1; zid < MAX_NR_ZONES; zid++) {
> --
> 2.17.0
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-09-03 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 8:54 [PATCH] mm/vmscan: get number of pages on the LRU list in memcgroup base on lru_zone_size Honglei Wang
2019-09-03 9:28 ` Michal Hocko [this message]
2019-09-04 7:38 ` Honglei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903092827.GP14028@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=honglei.wang@oracle.com \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).