From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA70CC49ED7 for ; Sat, 21 Sep 2019 00:13:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 680AB217F9 for ; Sat, 21 Sep 2019 00:13:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zrz20NN7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 680AB217F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C5DE36B0005; Fri, 20 Sep 2019 20:13:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0E166B0006; Fri, 20 Sep 2019 20:13:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B24546B0007; Fri, 20 Sep 2019 20:13:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 920366B0005 for ; Fri, 20 Sep 2019 20:13:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 26DB54826 for ; Sat, 21 Sep 2019 00:13:42 +0000 (UTC) X-FDA: 75957004284.22.pies79_779732ce9e73f X-HE-Tag: pies79_779732ce9e73f X-Filterd-Recvd-Size: 2655 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Sat, 21 Sep 2019 00:13:41 +0000 (UTC) Received: from localhost.localdomain (c-73-223-200-170.hsd1.ca.comcast.net [73.223.200.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C1C820C01; Sat, 21 Sep 2019 00:13:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569024820; bh=17JRz2amHdxSVooJ13gPyptXnx8eAB3apkUDMD7W4vc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Zrz20NN7PFy5ZN41xCLt4x7O4O9oeDirT1iTE0v4ix1M/eqKK/K6n9xtKke+NhQi5 /CjnzAS03Lwaq/qIadmBqnYx8xzIEBNDNjXy6fGUElfwbGhcZ/b89kHAzvXvNkGAAX HHRialNwDAHXLcgewgKIGPYXNfy8dWIU0DG4fTTo= Date: Fri, 20 Sep 2019 17:13:40 -0700 From: Andrew Morton To: Michal Hocko Cc: Joel Savitz , linux-kernel@vger.kernel.org, Rafael Aquini , David Rientjes , linux-mm@kvack.org Subject: Re: [RESEND PATCH v2] mm/oom_killer: Add task UID to info message on an oom kill Message-Id: <20190920171340.7591fd2899a06b5e7c390b76@linux-foundation.org> In-Reply-To: <20190613082318.GB9343@dhcp22.suse.cz> References: <1560362273-534-1-git-send-email-jsavitz@redhat.com> <20190613082318.GB9343@dhcp22.suse.cz> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 13 Jun 2019 10:23:18 +0200 Michal Hocko wrote: > On Wed 12-06-19 13:57:53, Joel Savitz wrote: > > In the event of an oom kill, useful information about the killed > > process is printed to dmesg. Users, especially system administrators, > > will find it useful to immediately see the UID of the process. > > Could you be more specific please? We already print uid when dumping > eligible tasks so it is not overly hard to find that information in the > oom report. Well, except when dumping of eligible tasks is disabled. Is > this what you are after? > > Please always be specific about usecases in the changelog. A terse > statement that something is useful doesn't tell much very often. > I'll add this to the chagnelog: : We already print uid when dumping eligible tasks so it is not overly hard : to find that information in the oom report. However this information is : unavailable then dumping of eligible tasks is disabled.