From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CD74C4320D for ; Tue, 24 Sep 2019 22:05:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD0E520872 for ; Tue, 24 Sep 2019 22:05:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OHpJEebm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD0E520872 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 776006B0007; Tue, 24 Sep 2019 18:05:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 726A96B0008; Tue, 24 Sep 2019 18:05:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 613F56B000A; Tue, 24 Sep 2019 18:05:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 3A5AE6B0007 for ; Tue, 24 Sep 2019 18:05:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id CD1A7180AD802 for ; Tue, 24 Sep 2019 22:05:56 +0000 (UTC) X-FDA: 75971197512.06.trees73_6e0fe5230b526 X-HE-Tag: trees73_6e0fe5230b526 X-Filterd-Recvd-Size: 5296 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Sep 2019 22:05:56 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id c6so8294011ioo.13 for ; Tue, 24 Sep 2019 15:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l11MQ+lA+OctjrXx4RVwP5DBxpG6bC0YG4oKg9f4dBc=; b=OHpJEebmt1koUbYUVd8ncvkV9ubqcGE7mtrWdS/c65uTLTqMphgV1caO7X4bPYYKIS f2A1vBtXhAq4sSHqbYEsgWREsC+eh4cYwwTEko1y7I7X/X9C4L8m4dCj+zCTdOxu9MOg z5WkbHoGkzNQt8S2Q64sRCVabMMZma3bVBqeaF42X5606EK03hy9wD8wUWFfVDAynwHT uwO8mqrqQQf35Jvi1RCtJfHzvYKK7r9TA7FXAzl0n7GcIlFhdV79K6W1FD8TJI8Eg9Qg Yotfk/n/C9BcCVCmd4G154js4Mko5Fpka3nFphpRFSKO/u9a7PBsYWEjQM5TA36D+vq8 F5bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l11MQ+lA+OctjrXx4RVwP5DBxpG6bC0YG4oKg9f4dBc=; b=ivXmdquzQg9NzneHitxqVgwePSnGNcJyStfsu2m3RCZU5bHPElC67zk61x14FS5Tjn BMb5Pq1/upqXewJLA6naiEZIHdqn0bGCZ9O2T0GO3PFjpcxqPLH8L65553yb0lx79EgQ nN9ma+g39O9isKsduYJz5524NojbZ6sqrYUD+S0bsPd5WuZbklGKvHmZl2AGFlToJiUz KMOr0UoXuhXeqjl2TKP5FFJuKohqkfzbdVBwUA59INkncTz7UPUgVKdJMFWRkscwDa7E w2gkUz2nQAhzZD0sjgsz4atyu00KGy7dWyVc6b4+Di9JN53zW5vVPtl69Wll5bqQ68Dx oAKA== X-Gm-Message-State: APjAAAUzXKWGnwL7/j06W7Mo5p90gYLXWqkCt4RaLF0dvKznIz/S1oki T9DHFQwB27HzP+n6YZ/mvpsCqA== X-Google-Smtp-Source: APXvYqy0q9UE81FUZmx9HjZuQrw+R0WHHAHqbnuLQUlSW8gIKlKykk3AQTIV+navbqB0cIVqup0GjQ== X-Received: by 2002:a02:683:: with SMTP id 125mr1373599jav.132.1569362755310; Tue, 24 Sep 2019 15:05:55 -0700 (PDT) Received: from google.com ([2620:15c:183:0:9f3b:444a:4649:ca05]) by smtp.gmail.com with ESMTPSA id v3sm5236863ioh.51.2019.09.24.15.05.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2019 15:05:54 -0700 (PDT) Date: Tue, 24 Sep 2019 16:05:50 -0600 From: Yu Zhao To: "Kirill A. Shutemov" Cc: Andrew Morton , Michal Hocko , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Kirill A . Shutemov" , Vlastimil Babka , Hugh Dickins , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrea Arcangeli , "Aneesh Kumar K . V" , David Rientjes , Matthew Wilcox , Lance Roy , Ralph Campbell , Jason Gunthorpe , Dave Airlie , Thomas Hellstrom , Souptick Joarder , Mel Gorman , Jan Kara , Mike Kravetz , Huang Ying , Aaron Lu , Omar Sandoval , Thomas Gleixner , Vineeth Remanan Pillai , Daniel Jordan , Mike Rapoport , Joel Fernandes , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: don't expose page to fast gup prematurely Message-ID: <20190924220550.GA123810@google.com> References: <20190514230751.GA70050@google.com> <20190914070518.112954-1-yuzhao@google.com> <20190924112316.324l7gqpdzhpiliq@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190924112316.324l7gqpdzhpiliq@box> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 24, 2019 at 02:23:16PM +0300, Kirill A. Shutemov wrote: > On Sat, Sep 14, 2019 at 01:05:18AM -0600, Yu Zhao wrote: > > We don't want to expose page to fast gup running on a remote CPU > > before all local non-atomic ops on page flags are visible first. > > > > For anon page that isn't in swap cache, we need to make sure all > > prior non-atomic ops, especially __SetPageSwapBacked() in > > page_add_new_anon_rmap(), are order before set_pte_at() to prevent > > the following race: > > > > CPU 1 CPU1 > > set_pte_at() get_user_pages_fast() > > page_add_new_anon_rmap() gup_pte_range() > > __SetPageSwapBacked() SetPageReferenced() > > Is there a particular codepath that has what you listed for CPU? > After quick look, I only saw that we page_add_new_anon_rmap() called > before set_pte_at(). I think so. One in do_swap_page() and another in unuse_pte(). Both are on KSM paths. Am I referencing a stale copy of the source?