From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88C5FC432C2 for ; Wed, 25 Sep 2019 22:04:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2DA5F20673 for ; Wed, 25 Sep 2019 22:04:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jblpeYxK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DA5F20673 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7FB786B0006; Wed, 25 Sep 2019 18:04:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7854D6B0007; Wed, 25 Sep 2019 18:04:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64BE66B0008; Wed, 25 Sep 2019 18:04:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 3E95F6B0006 for ; Wed, 25 Sep 2019 18:04:05 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id BEB3F181AC9C4 for ; Wed, 25 Sep 2019 22:04:04 +0000 (UTC) X-FDA: 75974821608.07.view37_677d1923e75d X-HE-Tag: view37_677d1923e75d X-Filterd-Recvd-Size: 5366 Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Sep 2019 22:04:04 +0000 (UTC) Received: by mail-io1-f67.google.com with SMTP id n197so949838iod.9 for ; Wed, 25 Sep 2019 15:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rhSXr0xwJou4CoHBVDkYpqEBKlvURobJgoh1V6NDSjs=; b=jblpeYxKQoyJmfsZMCmiDcmuM+FHKLJTEP5QO8aqTtsPSA162GLOOMY3I1QvTVagmR La3h7pZ71pbLo35PzU6woYBU3jvuLcYdgR1/NDzFhZYf/WRwZje7zyIuYHgi28z1703K 8nEZ9pnX5ZyvreXvrTK07tJ4OBeo0Dq/fPdMrXnydLlEde3EGaYx+0jhEq2wn7tjgYWM Q+dAosbXaZGoVrsNFmjknJ/M8YTn8mMKQmLadL54FxuQYRXZPyPv4mY5eXhLieCXbtJD s2C7LEcUR65NjG7xXUCtfyBtZOVFAjrza2HtAgB1GaVK/K4bk/U11pAdiSAAi5ZFpm6g k8Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rhSXr0xwJou4CoHBVDkYpqEBKlvURobJgoh1V6NDSjs=; b=eGlybxMc10L1x1fu9DPu07LArxs4O9G2p60F8aCi/3fvn07u8tExnzdyOMqUFVJjuh 2u+uUe3L+vpoWraM9loH1QwMBJNn6UPifuVY/QFh6STJSZlcv2peSOlVMcCDfw7ZdAam pZXMYjh2fwl+ItZaFJe+x3AUqo0olSjH2/hwoCt1TQsuSaM5kQWZMu42RnKWypPBCqfs pya0ok6eCOxKiIVegM0jSav20XadFno9zsLL9mwxBZXxiZV2OKxEn5kk+A4Gkw9AJUV2 BaKs3ctwBPdtb7zfxebIimn/EywiFIgBRIYnNyjGtEVZ8WI+VChMneZZbbqiP+k9AUNU sShA== X-Gm-Message-State: APjAAAVx5e/rCGWV65H3w/iWZWfGcYjLv5z4QVPFf/0JgbDBlYaGjAiw rR+4ddKZomtAWr6+9tZ4s89LJA== X-Google-Smtp-Source: APXvYqy0FhjpHx52fw8cVLnKaT3mISXokIpYLz5tzwz8cwp42mILIHWjKtVz8t1TqzCc2JV+cmz07g== X-Received: by 2002:a5e:d817:: with SMTP id l23mr232373iok.142.1569449043502; Wed, 25 Sep 2019 15:04:03 -0700 (PDT) Received: from google.com ([2620:15c:183:0:9f3b:444a:4649:ca05]) by smtp.gmail.com with ESMTPSA id t8sm58874ild.7.2019.09.25.15.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 15:04:02 -0700 (PDT) Date: Wed, 25 Sep 2019 16:03:57 -0600 From: Yu Zhao To: Matthew Wilcox Cc: Andrew Morton , Michal Hocko , "Kirill A . Shutemov" , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Vlastimil Babka , Hugh Dickins , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrea Arcangeli , "Aneesh Kumar K . V" , David Rientjes , Lance Roy , Ralph Campbell , Jason Gunthorpe , Dave Airlie , Thomas Hellstrom , Souptick Joarder , Mel Gorman , Jan Kara , Mike Kravetz , Huang Ying , Aaron Lu , Omar Sandoval , Thomas Gleixner , Vineeth Remanan Pillai , Daniel Jordan , Mike Rapoport , Joel Fernandes , Mark Rutland , Alexander Duyck , Pavel Tatashin , David Hildenbrand , Juergen Gross , Anthony Yznaga , Johannes Weiner , "Darrick J . Wong" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 4/4] mm: remove unnecessary smp_wmb() in __SetPageUptodate() Message-ID: <20190925220357.GA162930@google.com> References: <20190914070518.112954-1-yuzhao@google.com> <20190924232459.214097-1-yuzhao@google.com> <20190924232459.214097-4-yuzhao@google.com> <20190924235036.GA24516@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190924235036.GA24516@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 24, 2019 at 04:50:36PM -0700, Matthew Wilcox wrote: > On Tue, Sep 24, 2019 at 05:24:59PM -0600, Yu Zhao wrote: > > +/* > > + * Only use this function when there is a following write barrier, e.g., > > + * an explicit smp_wmb() and/or the page will be added to page or swap > > + * cache locked. > > + */ > > static __always_inline void __SetPageUptodate(struct page *page) > > { > > VM_BUG_ON_PAGE(PageTail(page), page); > > - smp_wmb(); > > __set_bit(PG_uptodate, &page->flags); > > } > > Isn't this now the same as __SETPAGEFLAG(uptodate, Uptodate, PF_NO_TAIL)? Indeed. I'll use the macro in the next version.