From: Michal Hocko <mhocko@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: Qian Cai <cai@lca.pw>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Dan Williams <dan.j.williams@intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock
Date: Thu, 26 Sep 2019 09:38:16 +0200 [thread overview]
Message-ID: <20190926073816.GC20255@dhcp22.suse.cz> (raw)
In-Reply-To: <17ba6fc6-72ce-992b-7cc4-812acbdedbeb@redhat.com>
On Thu 26-09-19 09:26:13, David Hildenbrand wrote:
[...]
> I'd like to hear what Michal thinks. If we do want the cpu hotplug lock,
> we can at least restrict it to the call paths (e.g., online_pages())
> where the lock is really needed and document that.
Completely agreed. Conflating cpu and memory hotplug locks was a bad
decision. If there are places which need both they should better use
both lock explicitly.
Now, the reality might turn out more complicated due to locks nesting
but hiding the cpu lock into the mem hotplug is just not fixing that.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-09-26 7:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 14:36 [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock David Hildenbrand
2019-09-24 14:48 ` Michal Hocko
2019-09-24 15:01 ` David Hildenbrand
2019-09-24 15:03 ` Qian Cai
2019-09-24 15:11 ` Michal Hocko
2019-09-24 18:54 ` Qian Cai
2019-09-25 7:02 ` David Hildenbrand
2019-09-25 16:01 ` Qian Cai
2019-09-25 17:48 ` Michal Hocko
2019-09-25 18:20 ` Qian Cai
2019-09-25 19:48 ` David Hildenbrand
2019-09-25 20:32 ` Qian Cai
2019-09-26 7:26 ` David Hildenbrand
2019-09-26 7:38 ` Michal Hocko [this message]
2019-09-26 7:26 ` Michal Hocko
2019-09-26 11:19 ` Qian Cai
2019-09-26 11:52 ` Michal Hocko
2019-09-26 13:02 ` Qian Cai
2019-09-26 13:14 ` David Hildenbrand
2019-09-25 10:03 ` Michal Hocko
2019-09-24 15:23 ` David Hildenbrand
2019-10-02 21:37 ` Qian Cai
2019-10-04 7:42 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926073816.GC20255@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).