From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADF5C352AA for ; Wed, 2 Oct 2019 07:53:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 58017218DE for ; Wed, 2 Oct 2019 07:53:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58017218DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E35298E0005; Wed, 2 Oct 2019 03:53:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE5938E0001; Wed, 2 Oct 2019 03:53:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4A188E0005; Wed, 2 Oct 2019 03:53:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id B71958E0001 for ; Wed, 2 Oct 2019 03:53:29 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 56894180AD7C3 for ; Wed, 2 Oct 2019 07:53:29 +0000 (UTC) X-FDA: 75998079738.20.milk73_75ba6e602f90e X-HE-Tag: milk73_75ba6e602f90e X-Filterd-Recvd-Size: 1698 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Oct 2019 07:53:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 45BBEAD73; Wed, 2 Oct 2019 07:53:27 +0000 (UTC) Date: Wed, 2 Oct 2019 09:53:26 +0200 From: Michal Hocko To: Qian Cai Cc: Arnd Bergmann , Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Shakeel Butt , Chris Down , Tejun Heo , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] mm/memcontrol.c: fix another unused function warning Message-ID: <20191002075326.GF15624@dhcp22.suse.cz> References: <20191001142227.1227176-1-arnd@arndb.de> <1569940805.5576.257.camel@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1569940805.5576.257.camel@lca.pw> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 01-10-19 10:40:05, Qian Cai wrote: > On Tue, 2019-10-01 at 16:22 +0200, Arnd Bergmann wrote: > > Removing the mem_cgroup_id_get() stub function introduced a new warning > > of the same kind when CONFIG_MMU is disabled: > > Shouldn't CONFIG_MEMCG depends on CONFIG_MMU instead? I wanted to do that in the past but there was a clear disagreement from Johannes. -- Michal Hocko SUSE Labs