From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B79C352AA for ; Wed, 2 Oct 2019 07:54:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1AB72218DE for ; Wed, 2 Oct 2019 07:54:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AB72218DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BEBB98E0005; Wed, 2 Oct 2019 03:54:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9B298E0001; Wed, 2 Oct 2019 03:54:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB0B78E0005; Wed, 2 Oct 2019 03:54:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 8B23A8E0001 for ; Wed, 2 Oct 2019 03:54:54 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id E51CE824CA3E for ; Wed, 2 Oct 2019 07:54:53 +0000 (UTC) X-FDA: 75998083266.11.cry04_8206b56907e3c X-HE-Tag: cry04_8206b56907e3c X-Filterd-Recvd-Size: 2309 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Oct 2019 07:54:53 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 21148ABF4; Wed, 2 Oct 2019 07:54:52 +0000 (UTC) Date: Wed, 2 Oct 2019 09:54:51 +0200 From: Michal Hocko To: Nick Desaulniers Cc: Arnd Bergmann , Johannes Weiner , Vladimir Davydov , Qian Cai , Andrew Morton , Roman Gushchin , Shakeel Butt , Chris Down , Tejun Heo , cgroups@vger.kernel.org, Linux Memory Management List , LKML , clang-built-linux Subject: Re: [PATCH] mm/memcontrol.c: fix another unused function warning Message-ID: <20191002075451.GG15624@dhcp22.suse.cz> References: <20191001142227.1227176-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 01-10-19 09:36:24, Nick Desaulniers wrote: > On Tue, Oct 1, 2019 at 7:22 AM Arnd Bergmann wrote: > > > > Removing the mem_cgroup_id_get() stub function introduced a new warning > > of the same kind when CONFIG_MMU is disabled: > > > > mm/memcontrol.c:4929:13: error: unused function 'mem_cgroup_id_get_many' [-Werror,-Wunused-function] > > > > Address this using a __maybe_unused annotation. > > > > Note: alternatively, this could be moved into an #ifdef block. Marking it > > Hi Arnd, > Thank you for the patch! I would prefer to move the definition to the > correct set of #ifdef guards rather than __maybe_unused. Maybe move > the definition of mem_cgroup_id_get_many() to just before > __mem_cgroup_clear_mc()? I find __maybe_unused to be a code smell. Agreed! -- Michal Hocko SUSE Labs