From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82845C4360C for ; Fri, 4 Oct 2019 17:46:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5FD212133F for ; Fri, 4 Oct 2019 17:46:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FD212133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E40956B0005; Fri, 4 Oct 2019 13:45:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF0EC6B0006; Fri, 4 Oct 2019 13:45:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2EED6B0008; Fri, 4 Oct 2019 13:45:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id B34B56B0005 for ; Fri, 4 Oct 2019 13:45:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 6422E8243768 for ; Fri, 4 Oct 2019 17:45:59 +0000 (UTC) X-FDA: 76006830438.13.form63_17212657a661b X-HE-Tag: form63_17212657a661b X-Filterd-Recvd-Size: 1698 Received: from Galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Oct 2019 17:45:58 +0000 (UTC) Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1iGReL-0008Mj-QN; Fri, 04 Oct 2019 19:45:53 +0200 Date: Fri, 4 Oct 2019 19:45:53 +0200 From: Sebastian Andrzej Siewior To: Uladzislau Rezki Cc: Daniel Wagner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] mm: vmalloc: Use the vmap_area_lock to protect ne_fit_preload_node Message-ID: <20191004174553.5fk2amnp4jblc7cy@linutronix.de> References: <20191003090906.1261-1-dwagner@suse.de> <20191004153728.c5xppuqwqcwecbe6@linutronix.de> <20191004162041.GA30806@pc636> <20191004163042.jpiau6dlxqylbpfh@linutronix.de> <20191004170411.GA31114@pc636> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191004170411.GA31114@pc636> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2019-10-04 19:04:11 [+0200], Uladzislau Rezki wrote: > if another, we can free the object allocated on previous step if > it already has it. If another CPU does not have it, save it in > ne_fit_preload_node for another current CPU to reuse later. Further > we can not migrate because of: > > > spin_lock(&vmap_area_lock); > preempt_enable(); > ah right. So you keep the lock later on, I somehow missed that part. That way it actually makes sense. Sebastian