* [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack
@ 2019-10-09 15:11 Ben Dooks
2019-10-09 15:37 ` Qian Cai
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2019-10-09 15:11 UTC (permalink / raw)
To: linux-kernel; +Cc: Ben Dooks, linux-mm, linux-kernel
Include <linux/huge_mm.h> for the definition of
is_vma_temporary_stack to fix the following
sparse warning:
mm/rmap.c:1673:6: warning: symbol 'is_vma_temporary_stack' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
---
mm/rmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/rmap.c b/mm/rmap.c
index d9a23bb773bf..0c7b2a9400d4 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -61,6 +61,7 @@
#include <linux/mmu_notifier.h>
#include <linux/migrate.h>
#include <linux/hugetlb.h>
+#include <linux/huge_mm.h>
#include <linux/backing-dev.h>
#include <linux/page_idle.h>
#include <linux/memremap.h>
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack
2019-10-09 15:11 [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack Ben Dooks
@ 2019-10-09 15:37 ` Qian Cai
2019-10-09 15:37 ` Qian Cai
0 siblings, 1 reply; 3+ messages in thread
From: Qian Cai @ 2019-10-09 15:37 UTC (permalink / raw)
To: Ben Dooks, linux-kernel; +Cc: linux-mm, linux-kernel
On Wed, 2019-10-09 at 16:11 +0100, Ben Dooks wrote:
> Include <linux/huge_mm.h> for the definition of
> is_vma_temporary_stack to fix the following
> sparse warning:
>
> mm/rmap.c:1673:6: warning: symbol 'is_vma_temporary_stack' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
It makes sense.
Reviewed-by: Qian Cai <cai@lca.pw>
> ---
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> ---
> mm/rmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/rmap.c b/mm/rmap.c
> index d9a23bb773bf..0c7b2a9400d4 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -61,6 +61,7 @@
> #include <linux/mmu_notifier.h>
> #include <linux/migrate.h>
> #include <linux/hugetlb.h>
> +#include <linux/huge_mm.h>
> #include <linux/backing-dev.h>
> #include <linux/page_idle.h>
> #include <linux/memremap.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack
2019-10-09 15:37 ` Qian Cai
@ 2019-10-09 15:37 ` Qian Cai
0 siblings, 0 replies; 3+ messages in thread
From: Qian Cai @ 2019-10-09 15:37 UTC (permalink / raw)
To: Ben Dooks, linux-kernel; +Cc: linux-mm, linux-kernel
On Wed, 2019-10-09 at 16:11 +0100, Ben Dooks wrote:
> Include <linux/huge_mm.h> for the definition of
> is_vma_temporary_stack to fix the following
> sparse warning:
>
> mm/rmap.c:1673:6: warning: symbol 'is_vma_temporary_stack' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
It makes sense.
Reviewed-by: Qian Cai <cai@lca.pw>
> ---
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> ---
> mm/rmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/rmap.c b/mm/rmap.c
> index d9a23bb773bf..0c7b2a9400d4 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -61,6 +61,7 @@
> #include <linux/mmu_notifier.h>
> #include <linux/migrate.h>
> #include <linux/hugetlb.h>
> +#include <linux/huge_mm.h>
> #include <linux/backing-dev.h>
> #include <linux/page_idle.h>
> #include <linux/memremap.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-13 2:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 15:11 [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack Ben Dooks
2019-10-09 15:37 ` Qian Cai
2019-10-09 15:37 ` Qian Cai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).