From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A0EDC47404 for ; Wed, 9 Oct 2019 18:45:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA6CC21848 for ; Wed, 9 Oct 2019 18:45:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=garybgenett-net.20150623.gappssmtp.com header.i=@garybgenett-net.20150623.gappssmtp.com header.b="NjrQFH4Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA6CC21848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=garybgenett.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5A6CE8E0005; Wed, 9 Oct 2019 14:45:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 556B98E0003; Wed, 9 Oct 2019 14:45:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 445D18E0005; Wed, 9 Oct 2019 14:45:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id 23C398E0003 for ; Wed, 9 Oct 2019 14:45:27 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id B5E6A181AC9AE for ; Wed, 9 Oct 2019 18:45:26 +0000 (UTC) X-FDA: 76025124252.29.hole17_69b044d94e85e X-HE-Tag: hole17_69b044d94e85e X-Filterd-Recvd-Size: 4640 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Oct 2019 18:45:26 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id p30so1991404pgl.2 for ; Wed, 09 Oct 2019 11:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garybgenett-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bKOpsdy86z81071OJ6MQHvmkMBFtdv7t0bmXf16vh1E=; b=NjrQFH4Q6IVCA94MmWM0J4SLhXzJeg7CtbBaTJrI/oTxs8XwUlp8x+gQe8uvY+hQtI CtUc6Inx8+MzH2Xa5LO310L7Ewmv+n8MDfVZG+hap5QgKn58yywFurg8au3VsL6r7cxH AzK3I08OWhioNwTddkx28uTtn5DTrcMuLMeuch7fUkt4vxAgFxETo5sLnF5QExIEAYjM NVU/KD0PWFGSEA48BE7tnH2YCglaob34Me5FtuzrJSAt4UQgujAsiL/sAe3ZsxNU/VBf SBarKsEu7dzFHPQBHFepmA1B0BPh+yk436Ypj0IW39rWQWr5LTmGJrOklAvflp2BrBgF XScQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=bKOpsdy86z81071OJ6MQHvmkMBFtdv7t0bmXf16vh1E=; b=CKMky/fyDdlFlve5qPtnNSPuQ6gQ7JjA1GByrnNwDGw6kpgVsM15IRWoxSjj5oW/Do P325CaXR9n8kwWnIp1+HeyN6T8wKUg75b8yujesGrM3zaRPC+tB+xD+G6c/MWnPVLQ42 oo5RD8tNi/sc1MEXMPHNVNLbCpnVg1Ok+DWPuVwzsD2sHyn6PfjHrOISHCdw0MJFueyl MhO87h6WpmjCuGNzkaSJsz8VUq3dbRQveD5MrZC+Mfavhnky0mYCqE2ttfRmkVmNCqoj y4ynpwuGR3DuX/9UI383CxxcPfOLR8OUG+3LXVQl84p1fHqjmnYI8IkjnYfL31wS5Iq5 rwkg== X-Gm-Message-State: APjAAAX2ZjofB2GN5vxL2hyZmhseN/1s6uEfarxbBhYzhI366aKVu6lx Q26vjhZ14moLR47ZoubySvJEMg== X-Google-Smtp-Source: APXvYqxIQfftQQIuOHbNXOCdBglFeFDC7H4PBTczFHhLhISqCrOegVTPdW/DJ1NlHsCcbwHau76i+A== X-Received: by 2002:a62:5bc1:: with SMTP id p184mr5262367pfb.139.1570646724551; Wed, 09 Oct 2019 11:45:24 -0700 (PDT) Received: from spider ([71.212.141.220]) by smtp.gmail.com with ESMTPSA id y6sm3608441pfp.82.2019.10.09.11.45.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Oct 2019 11:45:23 -0700 (PDT) Date: Wed, 9 Oct 2019 11:45:21 -0700 From: -Gary- To: Qian Cai , Vlastimil Babka Cc: Hugh Dickins , linux-mm@kvack.org Subject: Re: [PATCH] shmem: add shmem_size option for full filesystem Message-ID: <20191009184520.GE22291@spider> References: <20191008201710.GA21892@spider> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000171, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >From Qian: > Hide it under the EXPERT does not mean the bar is lower to justify when= introduced a new config option. What=E2=80=99s the benefits of this vs s= quashfs/resize? >From Vlastimil: > Users can override the default via a mount option, no? > Can the initramfs boot parameter specify the needed mount option > somehow? If not, could we detect that we are mounting an initramfs, and > size it accordingly over 50%? Do we know in advance how much we need? > I'd rather avoid a new config option for this, if possible. Thank you for clarifying all of that, Qian and Vlastimil. I have been ma= king the assumption, apparently mistaken, that adding kernel configuratio= n options is a trivial change. I stand educated. Thank you for your ongoing patience with my passion regarding this. I am= *not* a kernel developer, understand and appreciate the work involved, a= nd know there are many other important things which need attention. I concede, but am going to submit one final patch which simply makes the = value a define. My fundamental issue/fix here is that it is a magic token buried in the c= ode, and it should at least be a clearly defined default, as a matter of = principle. This will also make pre-compile sed/awk hacking much more rel= iable, for those so inclined. If even that change is unpalatable, I will graciously accept a simple "re= ject, based on previous discussion", with gratitude. <^) Thank you again for your consideration, and all of your hard work and con= tributions to the community. Happy Hacking! -- Gary