From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50869ECE58C for ; Wed, 9 Oct 2019 20:17:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BACDB206BB for ; Wed, 9 Oct 2019 20:17:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=garybgenett-net.20150623.gappssmtp.com header.i=@garybgenett-net.20150623.gappssmtp.com header.b="1MZ5F8Al" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BACDB206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=garybgenett.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4772B6B0003; Wed, 9 Oct 2019 16:17:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 427D48E0003; Wed, 9 Oct 2019 16:17:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EE556B0006; Wed, 9 Oct 2019 16:17:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 0823A6B0003 for ; Wed, 9 Oct 2019 16:17:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 66B5F18C9 for ; Wed, 9 Oct 2019 20:17:51 +0000 (UTC) X-FDA: 76025357142.01.crate87_276aadc6f2d1f X-HE-Tag: crate87_276aadc6f2d1f X-Filterd-Recvd-Size: 4211 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Oct 2019 20:17:50 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id p30so2148072pgl.2 for ; Wed, 09 Oct 2019 13:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garybgenett-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=K+eCWq0eA6B+AOnMBQ6aAxIVccd/PbU0mpxplyoi2Uw=; b=1MZ5F8AlFUZMmgXYDQVsRAAvzkf1gY+KyhQSG/hUGnnDEcxVfLeo0FTV9UzBFwZGMS TCi2y11LLp438NhyTzVNWv8z8kvwWm0EIOYv4NxCPY0zbNflOLAxRBv2+Aahc0zW94C/ /60m9bKIH36a5APJHSr3LBzpDuGGMlRgCPmSGGfwPEaha4rayxQ+p6vWrmvwnmFs7M+I gGb2yzxpYWkJ1GpNJr/SXgEgYN2/MMvnsIWP1SQzTOyjxCuTrexlgL3RMMP3/eKjhryD 0PC3tQsgQUpN/AODPf+9D7bNngGNUL1tCtqgxyBzQb5kfHE5p5aD37Af1xtdeHpUWKhz BpIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=K+eCWq0eA6B+AOnMBQ6aAxIVccd/PbU0mpxplyoi2Uw=; b=Iujz+8ucznEhsSf8Iq4CaYkbDKjAmpYPESIxCI0ofgizQmWLtUTndcZdvK6aJ0bFpe 4nwhBRMf57j8KO2UXAMIMM/1LtMAPnET25TQ80ww8HRBUoIislEGZ8f/kI9wXe7Fsgtp iTmsbi5Win4RoW+3s86C8bL84GSWJx1njGfrGcfjDz5fTAeB2GdM1dJpkG/2gH8emRkB x4rUGOeo3vcSpS+9/7SauqhbsCQQDuOMY/aGJ1Ambb8Pb8tlou2SQLwgwKeENp1M+Rl8 TE/6O4lvKXY8Rwqvi/TM7tfNHAqDNcH/ytJVqUBXJSLtE5ocM1W0pmAQMEKAyhqlse3g WYMg== X-Gm-Message-State: APjAAAXVofM4S0C4R0Xh9cRd7KXbiS3YwvPeYcCmXG0/b5ZdEq3H9y9s mbA7oEnwIdpTvJCVSRznqmM1gA== X-Google-Smtp-Source: APXvYqxBcG3Kz29AiBejwhN70YW5UnSTNEawDc3lX73NTewd9KxcRkHnPgFJPo7rZKzwUd3pWydYcg== X-Received: by 2002:a63:3e09:: with SMTP id l9mr6328268pga.328.1570652269083; Wed, 09 Oct 2019 13:17:49 -0700 (PDT) Received: from spider ([71.212.141.220]) by smtp.gmail.com with ESMTPSA id b3sm2926242pfd.125.2019.10.09.13.17.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Oct 2019 13:17:48 -0700 (PDT) Date: Wed, 9 Oct 2019 13:17:46 -0700 From: -Gary- To: Qian Cai Cc: Vlastimil Babka , Hugh Dickins , linux-mm@kvack.org Subject: Re: [PATCH] shmem: make shmem default size a define value Message-ID: <20191009201745.GF22291@spider> References: <20191009184604.GA5162@spider> <1570647695.5937.16.camel@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1570647695.5937.16.camel@lca.pw> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.021326, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > @@ -125,14 +128,14 @@ struct shmem_options { > > #ifdef CONFIG_TMPFS > > static unsigned long shmem_default_max_blocks(void) > > { > > - return totalram_pages() / 2; > > + return SHMEM_SIZE_DEFAULT; > > } > > > > static unsigned long shmem_default_max_inodes(void) > > { > > unsigned long nr_pages = totalram_pages(); > > This is now unused. Mind telling me what I missed, Qian? I pulled from: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git Latest commit is: 2019-10-08 15:36:04 -0700 e3280b54afed870d531571212f1fc375df39b7d2 Merge tag 'led-fixes-for-5.4-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds My patch is based on that, where the above code still exists, and nr_pages is still referenced below. Apparently, it is making totalram_pages atomic, according to the commit that changed it: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/mm/shmem.c?id=ca79b0c211af63fa3276f0e3fd7dd9ada2439839 Should I be pulling from somewhere else, or also re-hacking nr_pages somehow? -- Gary > > - return min(nr_pages - totalhigh_pages(), nr_pages / 2); > > + return min(nr_pages - totalhigh_pages(), SHMEM_SIZE_DEFAULT); > > } > > #endif