From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8EB5ECE58C for ; Wed, 9 Oct 2019 21:19:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6D10B218DE for ; Wed, 9 Oct 2019 21:19:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IElwFySM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D10B218DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 078566B0003; Wed, 9 Oct 2019 17:19:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 029678E0005; Wed, 9 Oct 2019 17:19:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5A318E0003; Wed, 9 Oct 2019 17:19:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id BDFC16B0003 for ; Wed, 9 Oct 2019 17:19:03 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 51E0A45A8 for ; Wed, 9 Oct 2019 21:19:03 +0000 (UTC) X-FDA: 76025511366.25.pin83_892df6f6ea330 X-HE-Tag: pin83_892df6f6ea330 X-Filterd-Recvd-Size: 5097 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Oct 2019 21:19:02 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id z12so2228076pgp.9 for ; Wed, 09 Oct 2019 14:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yIVzU+Q0uxcUt161uhYqfP3XsKR01P4YLhVu2FbVi3E=; b=IElwFySMYED1EECdhFj/UA9KqWeh68mdepLNVjqkB46MCKh7Vd0WHdQAc2HutK0/dn obYW+/5aA9BKVEeV63+7iBt07fKD/fIDojpUJWViLx7pYzR5BGz2g+beTgqBOCnVGs4x XKpKEkss0J+rprIl48Z9vUecQXatM2HGbIQi9mhwdsUPMZ+iqSwbIRmvshmkHCFHQ4iM P0WjQMcNRZVOYcNvp/HaYzE8VzGnbZEkOnge57htd+rG06/SHm88gyb0OcvWorQn2p+a MknWchyQFTctfA33GuFlgty0SenHEUEd6DWkBu+t6fJFq34XDxkyQySNjXRe6dC3GBp5 pfuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=yIVzU+Q0uxcUt161uhYqfP3XsKR01P4YLhVu2FbVi3E=; b=TDyS3GGlx72v4GEDwXMQl10kXtJF25ooiIt3B2l6CK9QtetCOwTcR+jNt6tFl8N7fR 0eZeekAcGq/61mPX8FE0C3rQroPHecN88TNyMfuK0/bD0cFgUJ1+hi+FwDh/z2EQkNn0 3kTLncfD0DRaY6wZVFXXj9uZc6nvYnHNwOCrIOpPz4EjFy4bB0vkEoUCILEWSRV2JliN UfT0oOfb35QhKkGteQGX9oEurJQ9zmbB52fwVVBqoDLRbDo+zyfMdQAMrnIqEsKiC4jh WcicQ7wUYWsf1u6sfiY2SOZu6wXmdgmKw5XT/FwMNqOormFiD1PKWWbmry1E5TZNaTzy NdJA== X-Gm-Message-State: APjAAAWpgyXJeIkvryjgCCWhYd+bL3X7nVjoUE+PiD9eAxt2ydud5scz XGKT2rbfG6Ugyl7F8sEk5pc= X-Google-Smtp-Source: APXvYqw2sNXhHHFIyhGh+CGGz179BRZrGUzG1ZAnoUqCoueTnKRiqdz3ZodwQmvEnqnXzp/uG3No6g== X-Received: by 2002:a63:a35f:: with SMTP id v31mr6539319pgn.51.1570655941446; Wed, 09 Oct 2019 14:19:01 -0700 (PDT) Received: from bbox-1.mtv.corp.google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id e14sm2610659pjt.8.2019.10.09.14.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 14:19:00 -0700 (PDT) From: Minchan Kim To: Andrew Morton Cc: LKML , linux-mm , Minchan Kim , Johannes Weiner Subject: [PATCH] fs: annotate refault stalls from bdev_read_page Date: Wed, 9 Oct 2019 14:18:57 -0700 Message-Id: <20191009211857.35587-1-minchan@kernel.org> X-Mailer: git-send-email 2.23.0.581.g78d2f28ef7-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Minchan Kim If block device supports rw_page operation, it doesn't submit bio so annotation in submit_bio for refault stall doesn't work. It happens with zram in android, especially swap read path which could consume CPU cycle for decompress. Annotate bdev_read_page() to account the synchronous IO overhead to prevent underreport memory pressure. Cc: Johannes Weiner Signed-off-by: Minchan Kim --- fs/block_dev.c | 13 +++++++++++++ mm/memory.c | 1 + 2 files changed, 14 insertions(+) diff --git a/fs/block_dev.c b/fs/block_dev.c index 9c073dbdc1b0..82ca28eb9a57 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -701,6 +702,8 @@ int bdev_read_page(struct block_device *bdev, sector_= t sector, { const struct block_device_operations *ops =3D bdev->bd_disk->fops; int result =3D -EOPNOTSUPP; + unsigned long pflags; + bool workingset_read; =20 if (!ops->rw_page || bdev_get_integrity(bdev)) return result; @@ -708,9 +711,19 @@ int bdev_read_page(struct block_device *bdev, sector= _t sector, result =3D blk_queue_enter(bdev->bd_queue, 0); if (result) return result; + + workingset_read =3D PageWorkingset(page); + if (workingset_read) + psi_memstall_enter(&pflags); + result =3D ops->rw_page(bdev, sector + get_start_sect(bdev), page, REQ_OP_READ); + + if (workingset_read) + psi_memstall_leave(&pflags); + blk_queue_exit(bdev->bd_queue); + return result; } EXPORT_SYMBOL_GPL(bdev_read_page); diff --git a/mm/memory.c b/mm/memory.c index 06935826d71e..6357d5a0a2a5 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2801,6 +2801,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) if (page) { __SetPageLocked(page); __SetPageSwapBacked(page); + SetPageWorkingset(page); set_page_private(page, entry.val); lru_cache_add_anon(page); swap_readpage(page, true); --=20 2.23.0.581.g78d2f28ef7-goog