From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52054C4360C for ; Thu, 10 Oct 2019 03:31:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 18125208C3 for ; Thu, 10 Oct 2019 03:31:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18125208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 889CB6B0003; Wed, 9 Oct 2019 23:31:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83AA28E0003; Wed, 9 Oct 2019 23:31:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72A136B0006; Wed, 9 Oct 2019 23:31:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 54F646B0003 for ; Wed, 9 Oct 2019 23:31:07 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 025E2181AC9AE for ; Thu, 10 Oct 2019 03:31:07 +0000 (UTC) X-FDA: 76026448974.21.spade58_26c75fe685e34 X-HE-Tag: spade58_26c75fe685e34 X-Filterd-Recvd-Size: 3059 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Oct 2019 03:31:06 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2019 20:31:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,278,1566889200"; d="scan'208";a="187824635" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga008.jf.intel.com with ESMTP; 09 Oct 2019 20:31:02 -0700 Date: Thu, 10 Oct 2019 11:30:45 +0800 From: Wei Yang To: Mike Kravetz Cc: Wei Yang , YueHaibing , Andrea Arcangeli , "Joel Fernandes (Google)" , Andrew Morton , Stephen Rothwell , Hugh Dickins , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] userfaultfd: remove set but not used variable 'h' Message-ID: <20191010033045.GA5927@richard> Reply-To: Wei Yang References: <20191009122740.70517-1-yuehaibing@huawei.com> <20191010012322.GB2167@richard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 09, 2019 at 07:25:18PM -0700, Mike Kravetz wrote: >On 10/9/19 6:23 PM, Wei Yang wrote: >> On Wed, Oct 09, 2019 at 05:45:57PM -0700, Mike Kravetz wrote: >>> On 10/9/19 5:27 AM, YueHaibing wrote: >>>> Fixes gcc '-Wunused-but-set-variable' warning: >>>> >>>> mm/userfaultfd.c: In function '__mcopy_atomic_hugetlb': >>>> mm/userfaultfd.c:217:17: warning: >>>> variable 'h' set but not used [-Wunused-but-set-variable] >>>> >>>> It is not used since commit 78911d0e18ac ("userfaultfd: use vma_pagesize >>>> for all huge page size calculation") >>>> >>> >>> Thanks! That should have been removed with the recent cleanups. >>> >>>> Signed-off-by: YueHaibing >>> >>> Reviewed-by: Mike Kravetz >> >> If I am correct, this is removed in a recent patch. > >I'm having a hard time figuring out what is actually in the latest mmotm >tree. Andrew added a build fixup patch ab169389eb5 in linux-next which >adds the reference to h. Is there a patch after that to remove the reference? > I checked linux-next tree, this commit removes the reference. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=add4eaeef3766b7491d70d473c48c0b6d6ca5cb7 >-- >Mike Kravetz -- Wei Yang Help you, Help me