From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E904C4360C for ; Thu, 10 Oct 2019 03:31:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E68D208C3 for ; Thu, 10 Oct 2019 03:31:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tw9ZuFDa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E68D208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE4C36B0005; Wed, 9 Oct 2019 23:31:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B95E86B0006; Wed, 9 Oct 2019 23:31:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A85568E0003; Wed, 9 Oct 2019 23:31:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id 8BA006B0005 for ; Wed, 9 Oct 2019 23:31:22 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 360E9180AD807 for ; Thu, 10 Oct 2019 03:31:22 +0000 (UTC) X-FDA: 76026449604.08.tub67_29027c52aa94b X-HE-Tag: tub67_29027c52aa94b X-Filterd-Recvd-Size: 3820 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Oct 2019 03:31:21 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id q10so2981950pfl.0 for ; Wed, 09 Oct 2019 20:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EnO8id/98/Qh00oP++9cNqpvu3+R/P/J/ThNLgVBNzs=; b=Tw9ZuFDaHYRgNgZD362SNUJRHFxDUPPcbti75sLjeVscqJ4Tv61OG92BDHXkKpaBl3 bzt0WkIM15GRPQUYtBUnkEwQQi/MSQSWDaDd8oNgaUMh8VljRwUvTd9S2hxsYt7ZmFWt OnGzQagLtpULwspyIZepZHpgJDOalHpzuXZVwHYCL4TASlwJJnEPAgTKe7LTT0L8RJBF V+604AMiG35rsOpmmR8ADKlCDwblGw0u1I+L4Hy10v96mwi5kLtv4cIIwaX9S/+PqM1A fnXoq3bIhOoyBw44tBoyo0MpuEGv4FXu1Bqb5eRyvSribufZkqnVG4qV1JQ7gmhsX86I jkmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EnO8id/98/Qh00oP++9cNqpvu3+R/P/J/ThNLgVBNzs=; b=aGVyPm2ACbxJKchxGunJ767K6/8WpS20JqeXEof5MjihQHQS7hUpZrW+zGV2oPQScb 3zyq8m3p7wEAPAy8Q2QP2iHf/nWaYaJ1HneHhvZOGiOWJwun9ae2oCIfQeePD0qQFxOG deAHig6yiA6AkmVpEIuYDUHVeyP57VUDCzhUPtb9UGwyNaSniz5hi2MWvrz4g24P1d6k vF440CkoIx9jA2NFLBXNVHiA7/oz20bGgCNCrRIu7N8QnXHc4IPcZMw5BlEtWKKRSWVD AVfdS7j1OhzOvebQ7qXUtAelHn/NRAUqqbGTfNzErslUQsyXRfLOEOO3PDACvkGiX7yw qAnQ== X-Gm-Message-State: APjAAAWpCAwzoMU0vXBw83HEy02vNFhQ43LHbBOXpAraJW2J06LeA7I7 ZBUGnnzV/l5rnwxVww7YBfAKfM29e24= X-Google-Smtp-Source: APXvYqzOh+V2GXOlquwSEivfnnshQObd0R9qJdVanwBG2BtfpcQ4SNcfBz2R5GRX4QuQnPKNDGuJKQ== X-Received: by 2002:a17:90a:8a89:: with SMTP id x9mr8350127pjn.95.1570678280483; Wed, 09 Oct 2019 20:31:20 -0700 (PDT) Received: from localhost.localdomain ([123.139.57.210]) by smtp.gmail.com with ESMTPSA id g20sm4159536pfo.73.2019.10.09.20.31.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 20:31:20 -0700 (PDT) From: Gaowei Pu To: Andrew Morton Cc: Vlastimil Babka , linux-mm@kvack.org Subject: [PATCH] mm/mmap.c: use IS_ERR_VALUE to check return value of get_unmapped_area Date: Thu, 10 Oct 2019 11:31:17 +0800 Message-Id: <20191010033117.22294-1-pugaowei@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: get_unmapped_area already cover the offset_in_page() check and returned with error ptr. So replace offset_in_page() with IS_ERR_VALUE(). Signed-off-by: Gaowei Pu --- mm/mmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 7e8c3e8ae75f..66cd88b2abb7 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1430,7 +1430,7 @@ unsigned long do_mmap(struct file *file, unsigned l= ong addr, * that it represents a valid section of the address space. */ addr =3D get_unmapped_area(file, addr, len, pgoff, flags); - if (offset_in_page(addr)) + if (IS_ERR_VALUE(addr)) return addr; =20 if (flags & MAP_FIXED_NOREPLACE) { @@ -2997,7 +2997,7 @@ static int do_brk_flags(unsigned long addr, unsigne= d long len, unsigned long fla flags |=3D VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT | mm->def_flags; =20 error =3D get_unmapped_area(NULL, addr, len, 0, MAP_FIXED); - if (offset_in_page(error)) + if (IS_ERR_VALUE(error)) return error; =20 error =3D mlock_future_check(mm, mm->def_flags, len); --=20 2.22.0