From: "Thomas Hellström (VMware)" <thomas_os@shipmail.org>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
torvalds@linux-foundation.org, kirill@shutemov.name
Cc: Thomas Hellstrom <thellstrom@vmware.com>
Subject: [RFC PATCH 2/4] fs: task_mmu: Have the pagewalk avoid positive callback return codes
Date: Thu, 10 Oct 2019 15:40:56 +0200 [thread overview]
Message-ID: <20191010134058.11949-3-thomas_os@shipmail.org> (raw)
In-Reply-To: <20191010134058.11949-1-thomas_os@shipmail.org>
From: Thomas Hellstrom <thellstrom@vmware.com>
The pagewalk code is being reworked to have positive callback return codes
mean "walk control". Avoid using positive return codes: "1" is replaced by
"-ENOBUFS".
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
---
fs/proc/task_mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 9442631fd4af..ef11969d9ba1 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -1265,7 +1265,7 @@ struct pagemapread {
#define PM_SWAP BIT_ULL(62)
#define PM_PRESENT BIT_ULL(63)
-#define PM_END_OF_BUFFER 1
+#define PM_END_OF_BUFFER (-ENOBUFS)
static inline pagemap_entry_t make_pme(u64 frame, u64 flags)
{
--
2.21.0
next prev parent reply other threads:[~2019-10-10 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 13:40 [RFC PATCH 0/4] mm: pagewalk: Rework callback return values and optionally skip the pte level Thomas Hellström (VMware)
2019-10-10 13:40 ` [RFC PATCH 1/4] mm: Have the mempolicy pagewalk to avoid positive callback return codes Thomas Hellström (VMware)
2019-10-11 13:08 ` Kirill A. Shutemov
2019-10-10 13:40 ` Thomas Hellström (VMware) [this message]
2019-10-10 13:40 ` [RFC PATCH 3/4] mm: pagewalk: Disallow user positive callback return values and use them for walk control Thomas Hellström (VMware)
2019-10-10 13:40 ` [RFC PATCH 4/4] mm: mapping_dirty_helpers: Handle huge pmds correctly Thomas Hellström (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010134058.11949-3-thomas_os@shipmail.org \
--to=thomas_os@shipmail.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=thellstrom@vmware.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).