From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79426ECE58E for ; Mon, 14 Oct 2019 10:49:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38BE920854 for ; Mon, 14 Oct 2019 10:49:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CIR2++nx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38BE920854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B70438E0005; Mon, 14 Oct 2019 06:49:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B20168E0001; Mon, 14 Oct 2019 06:49:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0E008E0005; Mon, 14 Oct 2019 06:49:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 7AAAA8E0001 for ; Mon, 14 Oct 2019 06:49:34 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 11E88180AD81A for ; Mon, 14 Oct 2019 10:49:34 +0000 (UTC) X-FDA: 76042069068.14.back92_193f5306a5f37 X-HE-Tag: back92_193f5306a5f37 X-Filterd-Recvd-Size: 3951 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 10:49:33 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id p1so9886564pgi.4 for ; Mon, 14 Oct 2019 03:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G8gq+lqSm5yWW7F43kBEhlO9mPcNo/sio34AqrTnoDs=; b=CIR2++nx6vd8Bz16k75idHqdvJPPUggJHKxR0wLUTH39CO7V5PzsdoM/D4Cl+k7hyo Gw7UFJe+mT5+cXWe9dIZ72glFDdSIFAbDa+G1XpiS+HtlwHLCMDZjNMrkE/g9VPFFBp+ R3mcqDEhevL++epc29HvSaFesu8qAIF86+zutNohVYL+deOc2iccMu4XOocxhlbYeCVN 7sMr5J6c50ESBVVdbsDa/VHCZzLy+oa8WGngXomAn3NyGRHltavsgM3JaDRkSnL6diQX YpOHyVJ5xETzTd3DzAft0NjYBLENis2h6cIfRDAawqTlsEABmHhWWpnfazaEWWQqyX/T fKgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G8gq+lqSm5yWW7F43kBEhlO9mPcNo/sio34AqrTnoDs=; b=eUKU7v0K3Frq9XdiDSa47/qr2QgDp7MW/62g7u61nA7f5D3w9zre5r2EIZ6VSVxltU cFYadt+hD9fzVyGqjVB9xT7AuUKd2LUQl+jIl1eZHGuSc6plWhMlmqJHyggtT9ahiDVI DwuFYZTV0WNB5bte62gsRljDy9BOmDM4GdfSRIT2+sva1HJVxUJ9dTOk/5bHBIxQixkD xsxhttGdVQzm1CtS8C1Wt9y/m0gQwfiqfp3bYxQhaDcEOkPKKxBtmuyz8q3Nms2eedSn dQD3zw5oudm2Rbi+8geoscgm1dzI/P5t3A3F4kqMQgk7WgtOg6rhgApfi8eqA2uCtnoA PlGA== X-Gm-Message-State: APjAAAVu5CCfXYTBDt01DPDqpek4XrvvcMFmp+9y9jNRKsqF5LRJhUEt WyizrkHPJZu6Cd6E4Sb78lQ= X-Google-Smtp-Source: APXvYqxK+ACvb4vfK9cMbR0YJ3hmK6bo06YPieT5XWqEJ3eDQ98ONnljFCgnR5I1vhonY95PgbLgOA== X-Received: by 2002:a17:90a:8002:: with SMTP id b2mr715256pjn.39.1571050172348; Mon, 14 Oct 2019 03:49:32 -0700 (PDT) Received: from localhost ([211.246.68.186]) by smtp.gmail.com with ESMTPSA id m68sm18688281pfb.122.2019.10.14.03.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 03:49:31 -0700 (PDT) Date: Mon, 14 Oct 2019 19:47:17 +0900 From: Sergey Senozhatsky To: Vitaly Wool Cc: Linux-MM , Andrew Morton , Dan Streetman , Minchan Kim , Sergey Senozhatsky , LKML , Vlastimil Babka , Shakeel Butt , Henry Burns , Theodore Ts'o Subject: Re: [PATCH 3/3] zram: use common zpool interface Message-ID: <20191014104717.GA43868@jagdpanzerIV> References: <20191010230414.647c29f34665ca26103879c4@gmail.com> <20191010232030.af6444879413e76a780cd27e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010232030.af6444879413e76a780cd27e@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (10/10/19 23:20), Vitaly Wool wrote: [..] > static const char *default_compressor = "lzo-rle"; > > +#define BACKEND_PAR_BUF_SIZE 32 > +static char backend_par_buf[BACKEND_PAR_BUF_SIZE]; We can have multiple zram devices (zram0 .. zramN), I guess it would make sense not to force all devices to use one particular allocator (e.g. see comp_algorithm_store()). If the motivation for the patch set is that zsmalloc does not perform equally well for various data access patterns, then the same is true for any other allocator. Thus, I think, we need to have a per-device 'allocator' knob. -ss