From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8818C4CECE for ; Mon, 14 Oct 2019 15:05:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6018821848 for ; Mon, 14 Oct 2019 15:05:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="o99ZYYOV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6018821848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B73748E0005; Mon, 14 Oct 2019 11:05:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B22E68E0001; Mon, 14 Oct 2019 11:05:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A10DF8E0005; Mon, 14 Oct 2019 11:05:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 7FD3F8E0001 for ; Mon, 14 Oct 2019 11:05:19 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 1BC99812C for ; Mon, 14 Oct 2019 15:05:19 +0000 (UTC) X-FDA: 76042713558.16.play76_4b6b504a3504b X-HE-Tag: play76_4b6b504a3504b X-Filterd-Recvd-Size: 2801 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 15:05:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5I0CZjdT/2pnYNFsgHQmuSO9JIMdOamZSLZFBh5OmRw=; b=o99ZYYOVu1tmiw7Abm9PzOv3P Va9JabPCGjikdbIolMWRy/pW42cZP+ZM0EGsWhlC9EWWSQ2xEHJEsHRaRCceD3xwlAr8q5LB0dYt7 tA3HjseMFc96j7CH8yS07sFe9QNgMOAxK64wSelG8GjP8iCqmRyfBm1KsFtXUVxfT9SvpvJOAQ168 dML17pRW7isucTPVwXPzK0bvMrmmdNsQ0BDrkbgCvxQfq/bSDneEKjIA4ux9VkKu1ZFSPD/KDY12A buIK92g4TXyyeoSXOMsXfZj1Fz/P89yXBay4uJO5eVqr3rTXlmPtuGPFLga7bI1V3eLvt8xE3of2w 0O6hI4Mrw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iK1uE-0007fP-VL; Mon, 14 Oct 2019 15:05:06 +0000 Date: Mon, 14 Oct 2019 08:05:06 -0700 From: Matthew Wilcox To: Walter Wu Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Matthias Brugger , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com Subject: Re: [PATCH 1/2] kasan: detect negative size in memory operation function Message-ID: <20191014150506.GX32665@bombadil.infradead.org> References: <20191014103632.17930-1-walter-zh.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191014103632.17930-1-walter-zh.wu@mediatek.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 14, 2019 at 06:36:32PM +0800, Walter Wu wrote: > @@ -110,8 +111,9 @@ void *memset(void *addr, int c, size_t len) > #undef memmove > void *memmove(void *dest, const void *src, size_t len) > { > - check_memory_region((unsigned long)src, len, false, _RET_IP_); > - check_memory_region((unsigned long)dest, len, true, _RET_IP_); > + if (!check_memory_region((unsigned long)src, len, false, _RET_IP_) || > + !check_memory_region((unsigned long)dest, len, true, _RET_IP_)) This indentation is wrong. Should be: + if (!check_memory_region((unsigned long)src, len, false, _RET_IP_) || + !check_memory_region((unsigned long)dest, len, true, _RET_IP_)) (also in one subsequent function)