From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95627C4CECE for ; Mon, 14 Oct 2019 16:45:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6215B20663 for ; Mon, 14 Oct 2019 16:45:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6215B20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D964F8E0005; Mon, 14 Oct 2019 12:45:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D208C8E0001; Mon, 14 Oct 2019 12:45:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC2088E0005; Mon, 14 Oct 2019 12:45:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 9A13F8E0001 for ; Mon, 14 Oct 2019 12:45:17 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 3E997181AEF30 for ; Mon, 14 Oct 2019 16:45:17 +0000 (UTC) X-FDA: 76042965474.10.rifle13_4b19a28af7429 X-HE-Tag: rifle13_4b19a28af7429 X-Filterd-Recvd-Size: 4629 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 16:45:15 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Oct 2019 09:45:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,296,1566889200"; d="scan'208";a="220152156" Received: from iweiny-desk2.sc.intel.com ([10.3.52.157]) by fmsmga004.fm.intel.com with ESMTP; 14 Oct 2019 09:45:12 -0700 Date: Mon, 14 Oct 2019 09:45:14 -0700 From: Ira Weiny To: "Aneesh Kumar K.V" Cc: "Kirill A. Shutemov" , John Hubbard , kbuild test robot , kbuild-all@lists.01.org, Andrew Morton , Christoph Hellwig , Keith Busch , LKML , linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH 2/2] mm/gup: fix a misnamed "write" argument: should be "flags" Message-ID: <20191014164513.GA6839@iweiny-DESK2.sc.intel.com> References: <20191013221155.382378-3-jhubbard@nvidia.com> <201910141316.DHpeevy3%lkp@intel.com> <20191014135234.7ak32pfir6du3xae@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 14, 2019 at 08:14:04PM +0530, Aneesh Kumar K.V wrote: > On 10/14/19 7:22 PM, Kirill A. Shutemov wrote: > > On Sun, Oct 13, 2019 at 11:43:10PM -0700, John Hubbard wrote: > > > On 10/13/19 11:12 PM, kbuild test robot wrote: > > > > Hi John, > > > > > > > > Thank you for the patch! Yet something to improve: > > > > > > > > [auto build test ERROR on linus/master] > > > > [cannot apply to v5.4-rc3 next-20191011] > > > > [if your patch is applied to the wrong git tree, please drop us a note to help > > > > improve the system. BTW, we also suggest to use '--base' option to specify the > > > > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > > > > > > > url: https://github.com/0day-ci/linux/commits/John-Hubbard/gup-c-gup_benchmark-c-trivial-fixes-before-the-storm/20191014-114158 > > > > config: powerpc-defconfig (attached as .config) > > > > compiler: powerpc64-linux-gcc (GCC) 7.4.0 > > > > reproduce: > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > > chmod +x ~/bin/make.cross > > > > # save the attached .config to linux build tree > > > > GCC_VERSION=7.4.0 make.cross ARCH=powerpc > > > > > > > > If you fix the issue, kindly add following tag > > > > Reported-by: kbuild test robot > > > > > > > > All errors (new ones prefixed by >>): > > > > > > > > mm/gup.c: In function 'gup_hugepte': > > > > > > mm/gup.c:1990:33: error: 'write' undeclared (first use in this function); did you mean 'writeq'? > > > > if (!pte_access_permitted(pte, write)) > > > > ^~~~~ > > > > writeq > > > > mm/gup.c:1990:33: note: each undeclared identifier is reported only once for each function it appears in > > > > > > > > > > OK, so this shows that my cross-compiler test scripts are faulty lately, > > > sorry I missed this. > > > > > > But more importantly, the above missed case is an example of when "write" really > > > means "write", as opposed to meaning flags. > > > > > > Please put this patch on hold or drop it, until we hear from the authors as to how > > > they would like to resolve this. I suspect it will end up as something like: > > > > > > bool write = (flags & FOLL_WRITE); > > > > > > ...perhaps? > > > > Just use > > > > if (!pte_access_permitted(pte, flags & FOLL_WRITE)) > > > > as we have in gup_pte_range(). > > > > And add: > > > > Fixes: cbd34da7dc9a ("mm: move the powerpc hugepd code to mm/gup.c") > > > > b798bec4741bdd80224214fdd004c8e52698e42 isn't this the commit that need to > be mentioned in the Fixes: tag? Yes, and while we are at it the type should probably be changed to unsigned int. Ira > > -aneesh