From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19879ECE58E for ; Mon, 14 Oct 2019 18:46:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D5B052067B for ; Mon, 14 Oct 2019 18:46:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Y6d1pU4Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5B052067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 85AF38E0006; Mon, 14 Oct 2019 14:46:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80BE68E0001; Mon, 14 Oct 2019 14:46:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 748F68E0006; Mon, 14 Oct 2019 14:46:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 57C698E0001 for ; Mon, 14 Oct 2019 14:46:43 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id F1DD8758D for ; Mon, 14 Oct 2019 18:46:42 +0000 (UTC) X-FDA: 76043271444.15.coach79_74c86a17fcc3b X-HE-Tag: coach79_74c86a17fcc3b X-Filterd-Recvd-Size: 4077 Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com [216.228.121.64]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 18:46:42 +0000 (UTC) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 14 Oct 2019 11:46:51 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 14 Oct 2019 11:46:41 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 14 Oct 2019 11:46:41 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 14 Oct 2019 18:46:40 +0000 Received: from hqnvemgw02.nvidia.com (172.16.227.111) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 14 Oct 2019 18:46:40 +0000 Received: from blueforge.nvidia.com (Not Verified[10.110.48.28]) by hqnvemgw02.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Mon, 14 Oct 2019 11:46:40 -0700 From: John Hubbard To: Andrew Morton CC: Christoph Hellwig , "Aneesh Kumar K . V" , Keith Busch , Ira Weiny , LKML , , John Hubbard , "Kirill A . Shutemov" , Shuah Khan , Subject: [PATCH v2 1/2] mm/gup_benchmark: add a missing "w" to getopt string Date: Mon, 14 Oct 2019 11:46:38 -0700 Message-ID: <20191014184639.1512873-2-jhubbard@nvidia.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191014184639.1512873-1-jhubbard@nvidia.com> References: <20191014184639.1512873-1-jhubbard@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1571078812; bh=5hKzjpJ7hSymwD+fnlyUM1PRMpQBY6h8z/VrTk1YOhY=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:X-NVConfidentiality: Content-Transfer-Encoding:Content-Type; b=Y6d1pU4QVkfR8c9VkZXMGDQnnOY+swROfYBkhaijQdhbwnELag/LF0A6xEqzhObzw UbWR+M1aIy+28ryAaHiZSRwh15dYpQGaaZdoZglf/2v9ZcONrupGl7TGm5yq/5LBD0 UaI6vIKzOt1VQ+prtisy8Ocm3kbs6Ky+Q+kypFH9denbWOid1cvGI7cFUaabIbCxsL rc1r798NSguwitOGWG7ysijZazXrhGd+ux9x6WhRXsxSE6NDLpay3GugeG94c2RVym 4Hl8svSHbiMEzC6QRcBbdu9wUtQmd0YtC0vWC7T3UGRP2CpC9cDDdjprfawFEV41aV w6pGf/nyZE05g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Even though gup_benchmark.c has code to handle the -w command-line option, the "w" is not part of the getopt string. It looks as if it has been missing the whole time. On my machine, this leads naturally to the following predictable result: $ sudo ./gup_benchmark -w ./gup_benchmark: invalid option -- 'w' ...which is fixed, with this commit. Acked-by: Kirill A. Shutemov Cc: Keith Busch Cc: Shuah Khan Cc: linux-kselftest@vger.kernel.org Signed-off-by: John Hubbard --- tools/testing/selftests/vm/gup_benchmark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/vm/gup_benchmark.c b/tools/testing/sel= ftests/vm/gup_benchmark.c index c0534e298b51..cb3fc09645c4 100644 --- a/tools/testing/selftests/vm/gup_benchmark.c +++ b/tools/testing/selftests/vm/gup_benchmark.c @@ -37,7 +37,7 @@ int main(int argc, char **argv) char *file =3D "/dev/zero"; char *p; =20 - while ((opt =3D getopt(argc, argv, "m:r:n:f:tTLUSH")) !=3D -1) { + while ((opt =3D getopt(argc, argv, "m:r:n:f:tTLUwSH")) !=3D -1) { switch (opt) { case 'm': size =3D atoi(optarg) * MB; --=20 2.23.0