From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C3E1ECE588 for ; Tue, 15 Oct 2019 10:31:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2589C20640 for ; Tue, 15 Oct 2019 10:31:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2589C20640 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 98EA58E0005; Tue, 15 Oct 2019 06:31:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 919798E0001; Tue, 15 Oct 2019 06:31:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 806888E0005; Tue, 15 Oct 2019 06:31:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 5963B8E0001 for ; Tue, 15 Oct 2019 06:31:05 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 01D928264491 for ; Tue, 15 Oct 2019 10:31:05 +0000 (UTC) X-FDA: 76045651290.12.brass46_439b8171c0f55 X-HE-Tag: brass46_439b8171c0f55 X-Filterd-Recvd-Size: 3143 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Oct 2019 10:31:04 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7E05FABE9; Tue, 15 Oct 2019 10:31:02 +0000 (UTC) Date: Tue, 15 Oct 2019 12:31:00 +0200 From: Michal Hocko To: Anshuman Khandual Cc: Mike Kravetz , akpm@linux-foundation.org, ard.biesheuvel@linaro.org, broonie@kernel.org, christophe.leroy@c-s.fr, dan.j.williams@intel.com, dave.hansen@intel.com, davem@davemloft.net, gerald.schaefer@de.ibm.com, gregkh@linuxfoundation.org, heiko.carstens@de.ibm.com, jgg@ziepe.ca, jhogan@kernel.org, keescook@chromium.org, kirill@shutemov.name, linux@armlinux.org.uk, mark.rutland@arm.com, mm-commits@vger.kernel.org, mpe@ellerman.id.au, paul.burton@mips.com, paulus@samba.org, penguin-kernel@i-love.sakura.ne.jp, peterz@infradead.org, ralf@linux-mips.org, rppt@linux.vnet.ibm.com, schowdary@nvidia.com, schwidefsky@de.ibm.com, Steven.Price@arm.com, tglx@linutronix.de, vbabka@suse.cz, vgupta@synopsys.com, willy@infradead.org, yamada.masahiro@socionext.com, linux-mm@kvack.org Subject: Re: + mm-hugetlb-make-alloc_gigantic_page-available-for-general-use.patch added to -mm tree Message-ID: <20191015103100.GV317@dhcp22.suse.cz> References: <20191011202932.GZoUOoURm%akpm@linux-foundation.org> <20191014121730.GE317@dhcp22.suse.cz> <89f328f0-ca00-a9b0-8df6-808a53bfcdd4@arm.com> <20191014130023.GF317@dhcp22.suse.cz> <87be189d-6fb5-1cfb-4a39-714e75ff866c@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87be189d-6fb5-1cfb-4a39-714e75ff866c@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 15-10-19 15:27:46, Anshuman Khandual wrote: > > > On 10/14/2019 10:22 PM, Mike Kravetz wrote: > > On 10/14/19 6:08 AM, Anshuman Khandual wrote: > >> On 10/14/2019 06:30 PM, Michal Hocko wrote: > >>> > >>> OK, thanks for the clarification. This all means that this patch is not > >>> the right approach. If you need a more generic alloc_contig_range then > >>> add it to page_alloc.c and make it completely independent on the hugetlb > >>> config and the code. Hugetlb allocator can reuse that helper. > > > > Should we revisit this previous attempt at such an interface? > > > > https://lkml.org/lkml/2018/4/16/1072 > > > > This looks like another use case. > > > > The current proposal [v6] does not go far enough to unify all callers > of alloc_contig_range() looking for contiguous pages of certain size, > but instead it just tries not to duplicate HugeTLB gigantic allocation > code in the test case for it's purpose. Please go and extract that functionality to a commonly usable helper. Dependency on hugetlb is just ugly as hell. -- Michal Hocko SUSE Labs