From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B61ECE58F for ; Tue, 15 Oct 2019 14:23:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD0CC20873 for ; Tue, 15 Oct 2019 14:23:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD0CC20873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 423FD8E0008; Tue, 15 Oct 2019 10:23:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D4F08E0001; Tue, 15 Oct 2019 10:23:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C34D8E0008; Tue, 15 Oct 2019 10:23:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 0A6718E0001 for ; Tue, 15 Oct 2019 10:23:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id A9F0382BC61F for ; Tue, 15 Oct 2019 14:23:49 +0000 (UTC) X-FDA: 76046237778.28.mist93_3e79111776449 X-HE-Tag: mist93_3e79111776449 X-Filterd-Recvd-Size: 2292 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Oct 2019 14:23:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6D9BBB2EA; Tue, 15 Oct 2019 14:23:47 +0000 (UTC) Date: Tue, 15 Oct 2019 16:23:44 +0200 From: Oscar Salvador To: Michal Hocko Cc: David Hildenbrand , Naoya Horiguchi , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Oscar Salvador Subject: Re: [PATCH v2 2/2] mm/memory-failure.c: Don't access uninitialized memmaps in memory_failure() Message-ID: <20191015142340.GA5686@linux> References: <20191009142435.3975-1-david@redhat.com> <20191009142435.3975-3-david@redhat.com> <20191009144323.GH6681@dhcp22.suse.cz> <5a626821-77e9-e26b-c2ee-219670283bf0@redhat.com> <20191010073526.GC18412@dhcp22.suse.cz> <18383432-c74a-9ce5-a3c6-1e57d54cb629@redhat.com> <52e81b85-c460-5b99-a297-e065caab3a16@redhat.com> <20191011060249.GA30500@hori.linux.bs1.fc.nec.co.jp> <3706d642-6c29-41b8-a676-1b5541af3169@redhat.com> <20191014133617.GJ317@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191014133617.GJ317@dhcp22.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 14, 2019 at 03:36:17PM +0200, Michal Hocko wrote: > I do agree. The two should be really using the same code. My > understanding was that MADV_HWPOISON was there to test the actual MCE > behavior (and the man page seems to agree with that). > > Oscar is working on a rewrite. Not sure he has considered this as well. Yeah, I came across hwpoison-inject module when doing my re-write, and I felt like this is begging for a clean up. Since unpoison_memory needs some adjustments after my re-write, I will go ahead and clean that up, otherwise it will be inconsistent. I expect to be ready fo send the v2 by the end of this week. Thanks -- Oscar Salvador SUSE L3