From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CE6ECE599 for ; Thu, 17 Oct 2019 00:49:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B177B218DE for ; Thu, 17 Oct 2019 00:49:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZF1baU1o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B177B218DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6079C8E0005; Wed, 16 Oct 2019 20:49:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DF378E0001; Wed, 16 Oct 2019 20:49:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51C8E8E0005; Wed, 16 Oct 2019 20:49:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 3276B8E0001 for ; Wed, 16 Oct 2019 20:49:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 9233252AC for ; Thu, 17 Oct 2019 00:49:57 +0000 (UTC) X-FDA: 76051444434.24.week98_39ce229263d12 X-HE-Tag: week98_39ce229263d12 X-Filterd-Recvd-Size: 3387 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Oct 2019 00:49:57 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC56420872; Thu, 17 Oct 2019 00:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571273396; bh=IYJzNb9unWNMZK55GWXexB0DpsKeOwmGxuFGk3dxhMA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZF1baU1o3y5gSgLWTM6fEbQK9smKG/HjbhMqyqekJ0qvU5Nm6MbJeLUHCSeNh5w3J tg3gDIAsXqpfhuNrM0faCk4eASmCQYMgKcHSZJkC4YFi7z7U1XUCR6tXGkZFgICAao UECGGb/C/2pSDVkEp9eeIi9yxgwjVWUtPiI79YTw= Date: Wed, 16 Oct 2019 17:49:55 -0700 From: Andrew Morton To: zhong jiang Cc: John Hubbard , Vlastimil Babka , , , , , Ira Weiny , "Aneesh Kumar K.V" Subject: Re: [PATCH] mm: Unsigned 'nr_pages' always larger than zero Message-Id: <20191016174955.300d5fd4968537151d3ad43f@linux-foundation.org> In-Reply-To: <5DA6DDE0.6000804@huawei.com> References: <1567592763-25282-1-git-send-email-zhongjiang@huawei.com> <5505fa16-117e-8890-0f48-38555a61a036@suse.cz> <20190904114820.42d9c4daf445ded3d0da52ab@linux-foundation.org> <73c49a1b-4f42-c21d-ccd8-2b063cdf1293@nvidia.com> <5DA6DDE0.6000804@huawei.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 16 Oct 2019 17:07:44 +0800 zhong jiang wrote: > >> --- a/mm/gup.c~a > >> +++ a/mm/gup.c > >> @@ -1450,6 +1450,7 @@ static long check_and_migrate_cma_pages( > >> bool drain_allow = true; > >> bool migrate_allow = true; > >> LIST_HEAD(cma_page_list); > >> + long ret; > >> check_again: > >> for (i = 0; i < nr_pages;) { > >> @@ -1511,17 +1512,18 @@ check_again: > >> * again migrating any new CMA pages which we failed to isolate > >> * earlier. > >> */ > >> - nr_pages = __get_user_pages_locked(tsk, mm, start, nr_pages, > >> + ret = __get_user_pages_locked(tsk, mm, start, nr_pages, > >> pages, vmas, NULL, > >> gup_flags); > >> - if ((nr_pages > 0) && migrate_allow) { > >> + nr_pages = ret; > >> + if (ret > 0 && migrate_allow) { > >> drain_allow = true; > >> goto check_again; > >> } > >> } > >> - return nr_pages; > >> + return ret; > >> } > >> #else > >> static long check_and_migrate_cma_pages(struct task_struct *tsk, > >> > > > > +1 for this approach, please. > > > > > > thanks, > Hi, Andrew > > I didn't see the fix for the issue in the upstream. Your proposal should be > appiled to upstream. Could you appiled the patch or repost by me ? Forgotten about it ;) Please send a patch sometime?