From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7B3CA9EAE for ; Wed, 23 Oct 2019 06:51:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 910752064A for ; Wed, 23 Oct 2019 06:51:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 910752064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 28C9F6B0003; Wed, 23 Oct 2019 02:51:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 215766B0006; Wed, 23 Oct 2019 02:51:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 104C66B0007; Wed, 23 Oct 2019 02:51:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id DE0696B0003 for ; Wed, 23 Oct 2019 02:51:00 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 8F52262C4 for ; Wed, 23 Oct 2019 06:51:00 +0000 (UTC) X-FDA: 76074127080.15.guide81_42f84d50c3735 X-HE-Tag: guide81_42f84d50c3735 X-Filterd-Recvd-Size: 1976 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Oct 2019 06:51:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9B113B549; Wed, 23 Oct 2019 06:50:58 +0000 (UTC) Date: Wed, 23 Oct 2019 08:50:57 +0200 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/2] mm: memcontrol: remove dead code from memory_max_write() Message-ID: <20191023065057.GC754@dhcp22.suse.cz> References: <20191022201518.341216-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191022201518.341216-1-hannes@cmpxchg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 22-10-19 16:15:17, Johannes Weiner wrote: > When the reclaim loop in memory_max_write() is ^C'd or similar, we set > err to -EINTR. But we don't return err. Once the limit is set, we > always return success (nbytes). Delete the dead code. > > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko > --- > mm/memcontrol.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 055975b0b3a3..ff90d4e7df37 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -6122,10 +6122,8 @@ static ssize_t memory_max_write(struct kernfs_open_file *of, > if (nr_pages <= max) > break; > > - if (signal_pending(current)) { > - err = -EINTR; > + if (signal_pending(current)) > break; > - } > > if (!drained) { > drain_all_stock(memcg); > -- > 2.23.0 > -- Michal Hocko SUSE Labs