From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9012CA9EB6 for ; Wed, 23 Oct 2019 14:31:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 93CF02173B for ; Wed, 23 Oct 2019 14:31:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93CF02173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 43F016B000C; Wed, 23 Oct 2019 10:31:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EE536B000D; Wed, 23 Oct 2019 10:31:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 305736B000E; Wed, 23 Oct 2019 10:31:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 0F8946B000C for ; Wed, 23 Oct 2019 10:31:06 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id ACE6E68B9 for ; Wed, 23 Oct 2019 14:31:05 +0000 (UTC) X-FDA: 76075286490.04.horse68_979ea3de044f X-HE-Tag: horse68_979ea3de044f X-Filterd-Recvd-Size: 4311 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Oct 2019 14:31:04 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A5D9AB442; Wed, 23 Oct 2019 14:31:03 +0000 (UTC) Date: Wed, 23 Oct 2019 16:31:02 +0200 From: Michal Hocko To: Vlastimil Babka Cc: Andrew Morton , Mel Gorman , Waiman Long , Johannes Weiner , Roman Gushchin , Konstantin Khlebnikov , Jann Horn , Song Liu , Greg Kroah-Hartman , Rafael Aquini , linux-mm@kvack.org, LKML Subject: Re: [RFC PATCH 2/2] mm, vmstat: reduce zone->lock holding time by /proc/pagetypeinfo Message-ID: <20191023143102.GI17610@dhcp22.suse.cz> References: <20191023095607.GE3016@techsingularity.net> <20191023102737.32274-1-mhocko@kernel.org> <20191023102737.32274-3-mhocko@kernel.org> <30211965-8ad0-416d-0fe1-113270bd1ea8@suse.cz> <20191023133720.GA17610@dhcp22.suse.cz> <7fb34979-66a4-4a5d-1798-402826e31e72@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7fb34979-66a4-4a5d-1798-402826e31e72@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 23-10-19 15:48:36, Vlastimil Babka wrote: > On 10/23/19 3:37 PM, Michal Hocko wrote: > > On Wed 23-10-19 15:32:05, Vlastimil Babka wrote: > >> On 10/23/19 12:27 PM, Michal Hocko wrote: > >>> From: Michal Hocko > >>> > >>> pagetypeinfo_showfree_print is called by zone->lock held in irq mode. > >>> This is not really nice because it blocks both any interrupts on that > >>> cpu and the page allocator. On large machines this might even trigger > >>> the hard lockup detector. > >>> > >>> Considering the pagetypeinfo is a debugging tool we do not really need > >>> exact numbers here. The primary reason to look at the outuput is to see > >>> how pageblocks are spread among different migratetypes therefore putting > >>> a bound on the number of pages on the free_list sounds like a reasonable > >>> tradeoff. > >>> > >>> The new output will simply tell > >>> [...] > >>> Node 6, zone Normal, type Movable >100000 >100000 >100000 >100000 41019 31560 23996 10054 3229 983 648 > >>> > >>> instead of > >>> Node 6, zone Normal, type Movable 399568 294127 221558 102119 41019 31560 23996 10054 3229 983 648 > >>> > >>> The limit has been chosen arbitrary and it is a subject of a future > >>> change should there be a need for that. > >>> > >>> Suggested-by: Andrew Morton > >>> Signed-off-by: Michal Hocko > >> > >> Hmm dunno, I would rather e.g. hide the file behind some config or boot > >> option than do this. Or move it to /sys/kernel/debug ? > > > > But those wouldn't really help to prevent from the lockup, right? > > No, but it would perhaps help ensure that only people who know what they > are doing (or been told so by a developer e.g. on linux-mm) will try to > collect the data, and not some automatic monitoring tools taking > periodic snapshots of stuff in /proc that looks interesting. Well, we do trust root doesn't do harm, right? > > Besides that who would enable that config and how much of a difference > > would root only vs. debugfs make? > > I would hope those tools don't scrap debugfs as much as /proc, but I > might be wrong of course :) > > > Is the incomplete value a real problem? > > Hmm perhaps not. If the overflow happens only for one migratetype, one > can use also /proc/buddyinfo to get to the exact count, as was proposed > in this thread for Movable migratetype. Let's say this won't be the case. What is the worst case that the imprecision would cause? In other words. Does it really matter whether we have 100k pages on the free list of the specific migrate type for order or say 200k? -- Michal Hocko SUSE Labs