From: Michal Hocko <mhocko@kernel.org>
To: Hillf Danton <hdanton@sina.com>
Cc: linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Chris Down <chris@chrisdown.name>, Tejun Heo <tj@kernel.org>,
Roman Gushchin <guro@fb.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
Matthew Wilcox <willy@infradead.org>,
Minchan Kim <minchan@kernel.org>, Mel Gorman <mgorman@suse.de>
Subject: Re: [RFC v2] memcg: add memcg lru for page reclaiming
Date: Tue, 29 Oct 2019 09:37:30 +0100 [thread overview]
Message-ID: <20191029083730.GC31513@dhcp22.suse.cz> (raw)
In-Reply-To: <20191026110745.12956-1-hdanton@sina.com>
On Sat 26-10-19 19:07:45, Hillf Danton wrote:
>
> Currently soft limit reclaim is frozen, see
> Documentation/admin-guide/cgroup-v2.rst for reasons.
>
> This work adds memcg hook into kswapd's logic to bypass slr,
> paving a brick for its cleanup later.
>
> After b23afb93d317 ("memcg: punt high overage reclaim to
> return-to-userland path"), high limit breachers are reclaimed one
> after another spiraling up through the memcg hierarchy before
> returning to userspace.
>
> We can not add new hook yet if it is infeasible to defer that
> reclaiming a bit further until kswapd becomes active.
>
> It can be defered however because high limit breach looks benign
> in the absence of memory pressure, or we ensure it will be
> reclaimed soon in the presence of kswapd.
This is not true and I have already expressed that in a responsoce to
the v1 of this patch. Let me repeat (for the last time hopefully) the
high limit is aimed at throttling allocators even when the system is not
under a memory pressure. So no, we cannot defer to kswapd.
This patchset is ignoring the previous review feedback. You still
haven't described any real usecase and any reasons why the existing
feature list doesn't satisfy it.
Until this is sorted out:
Nacked-by: Michal Hocko <mhocko@suse.com>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-10-29 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 11:07 [RFC v2] memcg: add memcg lru for page reclaiming Hillf Danton
2019-10-29 8:37 ` Michal Hocko [this message]
2019-10-29 15:46 ` Johannes Weiner
2019-11-07 9:02 ` [memcg] 1fc14cf673: invoked_oom-killer:gfp_mask=0x kernel test robot
2019-11-08 4:01 ` Hillf Danton
2019-11-09 12:19 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029083730.GC31513@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).