From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 923A4CA9ECF for ; Fri, 1 Nov 2019 15:08:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 329C921734 for ; Fri, 1 Nov 2019 15:08:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k0KsNRPR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 329C921734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8BC0D6B0005; Fri, 1 Nov 2019 11:08:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86CC76B0007; Fri, 1 Nov 2019 11:08:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75A9F6B0276; Fri, 1 Nov 2019 11:08:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id 4FCBE6B0005 for ; Fri, 1 Nov 2019 11:08:19 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id B383E180AD801 for ; Fri, 1 Nov 2019 15:08:18 +0000 (UTC) X-FDA: 76108039476.06.smile83_82b295d32c509 X-HE-Tag: smile83_82b295d32c509 X-Filterd-Recvd-Size: 5839 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 Nov 2019 15:08:18 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id e4so6687950pgs.1 for ; Fri, 01 Nov 2019 08:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3uvuNtUMz3KodzzKNpROMgOvL1d1saTuVjo2u9aF76g=; b=k0KsNRPRjaYycmcwFtMZ3C0jOvhWjdSkPglmuQXLHQf6VVfQQOsoK1l8Qc/LyrY4HB M9pL8mOQd+nXsHxMYAq0JDSGKQg7prpTtia7RJLgM9mt+PaYkY9Bmu5RXlh28TwyfPA4 lUcVV//epKZu5JWkSnLUc+afGksq/V3740R0lOMy6hJIBZmN+Rv+ny2VI20mMVPeXy6B 78QxF1cToWgB9/Lfy6GIMkR/l29fsRhpuh+6ryAqUqO17cWcjrnCdX0qtBzhpSiY3FjM S/zqIaXf9WzYpu5GP7OE5n3dfHRhWLZ4eDfSkjMbTx0Evpn43J/CxjcGo32rE8kcWDKL oKbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=3uvuNtUMz3KodzzKNpROMgOvL1d1saTuVjo2u9aF76g=; b=B0FmLgYgzOu8M5AHtHLmj/kcrFJi38PDMLJAzLIae91RKn6yOt1+KKHrwM+yZOQNd1 qy6eLgkUDY/WGH39q7bjXRJfth0YRTkdY8qiwNMfwNQq7DXc+AXrVLmq4zoe6YPox4Qm XtrT52Ms+Wajp1gjdpZghCn0Fdirs3H2k/PeUv66XTm41BNabt8Rx0fulQ+aHszUNLWX LsNiH6rB/37k1rhfS8wbljyMUOK8IoAibq0vJlckTy48pX8Iv1gsgu9QPO0bZQAEdb+L jp2wbtri1OWSMtJvBl9pjzkb4mmXQZqFbbVLSQfcQ4ZObDK0AJtI4aiSpmq6TsX+4t1s S4Qg== X-Gm-Message-State: APjAAAXVBcMZxVdmeQ+AAYc3TTqRvP2b+z/Vr1lI8+Mcin5pcklv7/V9 N4DVdYx1EwCJCEs/kiKpzU0= X-Google-Smtp-Source: APXvYqzjgSxnbMb/0MKzUf/ZHaeiUHmMfh0Qgn5XlVKa7xOWutmT+R2cxr7GCzODAcO1NE9mA7EpAQ== X-Received: by 2002:a17:90a:634c:: with SMTP id v12mr1411585pjs.27.1572620896333; Fri, 01 Nov 2019 08:08:16 -0700 (PDT) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id x10sm1719424pfn.36.2019.11.01.08.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 08:08:15 -0700 (PDT) Date: Fri, 1 Nov 2019 08:08:13 -0700 From: Minchan Kim To: zhong jiang Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm: fix trying to reclaim unevictable lru page when calling madvise_pageout Message-ID: <20191101150813.GA101471@google.com> References: <1572616245-18946-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572616245-18946-1-git-send-email-zhongjiang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 01, 2019 at 09:50:45PM +0800, zhong jiang wrote: > Recently, I hit the following issue when running in the upstream. > > kernel BUG at mm/vmscan.c:1521! > invalid opcode: 0000 [#1] SMP KASAN PTI > CPU: 0 PID: 23385 Comm: syz-executor.6 Not tainted 5.4.0-rc4+ #1 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014 > RIP: 0010:shrink_page_list+0x12b6/0x3530 mm/vmscan.c:1521 > Code: de f5 ff ff e8 ab 79 eb ff 4c 89 f7 e8 43 33 0d 00 e9 cc f5 ff ff e8 99 79 eb ff 48 c7 c6 a0 34 2b a0 4c 89 f7 e8 1a 4d 05 00 <0f> 0b e8 83 79 eb ff 48 89 d8 48 c1 e8 03 42 80 3c 38 00 0f 85 74 > RSP: 0018:ffff88819a3df5a0 EFLAGS: 00010286 > RAX: 0000000000040000 RBX: ffffea00061c3980 RCX: ffffffff814fba36 > RDX: 00000000000056f7 RSI: ffffc9000c02c000 RDI: ffff8881f70268cc > RBP: ffff88819a3df898 R08: ffffed103ee05de0 R09: ffffed103ee05de0 > R10: 0000000000000001 R11: ffffed103ee05ddf R12: ffff88819a3df6f0 > R13: ffff88819a3df6f0 R14: ffffea00061c3980 R15: dffffc0000000000 > FS: 00007f21b9d8e700(0000) GS:ffff8881f7000000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000001b2d621000 CR3: 00000001c8c46004 CR4: 00000000007606f0 > DR0: 0000000020000140 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000600 > PKRU: 55555554 > Call Trace: > reclaim_pages+0x499/0x800 mm/vmscan.c:2188 > madvise_cold_or_pageout_pte_range+0x58a/0x710 mm/madvise.c:453 > walk_pmd_range mm/pagewalk.c:53 [inline] > walk_pud_range mm/pagewalk.c:112 [inline] > walk_p4d_range mm/pagewalk.c:139 [inline] > walk_pgd_range mm/pagewalk.c:166 [inline] > __walk_page_range+0x45a/0xc20 mm/pagewalk.c:261 > walk_page_range+0x179/0x310 mm/pagewalk.c:349 > madvise_pageout_page_range mm/madvise.c:506 [inline] > madvise_pageout+0x1f0/0x330 mm/madvise.c:542 > madvise_vma mm/madvise.c:931 [inline] > __do_sys_madvise+0x7d2/0x1600 mm/madvise.c:1113 > do_syscall_64+0x9f/0x4c0 arch/x86/entry/common.c:290 > entry_SYSCALL_64_after_hwframe+0x49/0xbe > > madvise_pageout access the specified range of the vma and isolate > them, then run shrink_page_list to reclaim its memory. But It also > isolate the unevictable page to reclaim. Hence, we can catch the > cases in shrink_page_list. > > The root cause is that we scan the page tables instead of specific > LRU list. and so we need to filter out the unevictable lru pages > from our end. > > Fixes: 1a4e58cce84e ("mm: introduce MADV_PAGEOUT") > Cc: stable@vger.kernel.org > Suggested-by: Johannes Weiner > Signed-off-by: zhong jiang Acked-by: Minchan Kim Thanks for the fix.