From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0610CA9ECF for ; Fri, 1 Nov 2019 18:26:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 95C382086D for ; Fri, 1 Nov 2019 18:26:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="JWQs9dhn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95C382086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 436F66B0007; Fri, 1 Nov 2019 14:26:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 418DC6B0008; Fri, 1 Nov 2019 14:26:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 324166B000A; Fri, 1 Nov 2019 14:26:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 1A2B56B0007 for ; Fri, 1 Nov 2019 14:26:15 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id D03568E4A for ; Fri, 1 Nov 2019 18:26:14 +0000 (UTC) X-FDA: 76108538268.27.verse98_70b2a6ef57a5b X-HE-Tag: verse98_70b2a6ef57a5b X-Filterd-Recvd-Size: 5269 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 Nov 2019 18:26:14 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id o49so14086279qta.7 for ; Fri, 01 Nov 2019 11:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Gf48vjpUJOI371bNO6wuyPSeEKQoVC5o/vcfCQf27GI=; b=JWQs9dhnB75sOXYZXe00Sx8Ycjn6wXVLJb4bA4loebrzhAwONRCd3M5hdaM0XcPXz1 0pyWtlLrDj1njuvPs0zQ0ulMeEyYu9AvLupxmw9YV4Vil+0G3KASfmA7bMmkBjsVbLm0 NwKPrT73FZLPw9yxM2LsvyNjyyW57QaAakB9IZRdrjquWCFH5qzR698e9e1ojGeAZOIU KBToGNUChheA/LNzlqzqO22UYmvZ00/yxcgviEIwglK7aIkeobtD5FAioyP3loLN1pgO xAWVbCdTVv2/yYYX7qXzDiZnl3pkn6y+wuJtS5dp5Cn2pGV9z3geaSwd6yE4+Biq0CTg qgMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Gf48vjpUJOI371bNO6wuyPSeEKQoVC5o/vcfCQf27GI=; b=T2HFpWGEYHbXw0SzO1MpivMxhcUeVjXgie2uczAr1P4xwXOxtCnYh0jf/zlPjOD9fd NosZQJNFzAkGG2cPWarmN8MWVKFodE4u4Rc6qLgQObdaNeCG2HNeX5ZvtYShE4at9n27 3oogGp3HB6BTwVQYfahDZKbH/aIoyjXO6IcIRSssAPTgpKQ3azyJqHcCnyHwMqjDzoRx NT4iOr1O8AVaXcqJLIgM1i16hnrCLfBm3EZpq3oQykmrt5TLrQvNrbLHI+XIULAOjVNZ bfa6worm5fwpRHFEW9sB4opRAhS36NK/nNcwObYj7/aqJpyQXICAWGOLjR8mbWOlne0B 8REg== X-Gm-Message-State: APjAAAXe8mHYYDpVcxwdnc6hEaS9CPnis0HAyUiutpvI88a1/V1eo0fm 92feAwksh05mxQK7wPGK79eI6Mn9n8U= X-Google-Smtp-Source: APXvYqxlEpFiUQP9ickqdfrdsM0skeumHMpJp062tTi17mtiKR8bSsZEkpehUJ8EZgMrejKnz1agZQ== X-Received: by 2002:a0c:8884:: with SMTP id 4mr11433684qvn.248.1572632773480; Fri, 01 Nov 2019 11:26:13 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id x10sm5932634qtj.25.2019.11.01.11.26.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Nov 2019 11:26:12 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iQbci-0008HC-0J; Fri, 01 Nov 2019 15:26:12 -0300 Date: Fri, 1 Nov 2019 15:26:11 -0300 From: Jason Gunthorpe To: linux-mm@kvack.org, Jerome Glisse , Ralph Campbell , John Hubbard , Felix.Kuehling@amd.com Cc: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Alex Deucher , Ben Skeggs , Boris Ostrovsky , Christian =?utf-8?B?S8O2bmln?= , David Zhou , Dennis Dalessandro , Juergen Gross , Mike Marciniszyn , Oleksandr Andrushchenko , Petr Cvek , Stefano Stabellini , nouveau@lists.freedesktop.org, xen-devel@lists.xenproject.org, Christoph Hellwig Subject: Re: [PATCH v2 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER Message-ID: <20191101182611.GA31478@ziepe.ca> References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-9-jgg@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191028201032.6352-9-jgg@ziepe.ca> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 28, 2019 at 05:10:25PM -0300, Jason Gunthorpe wrote: > From: Jason Gunthorpe > > DMA_SHARED_BUFFER can not be enabled by the user (it represents a library > set in the kernel). The kconfig convention is to use select for such > symbols so they are turned on implicitly when the user enables a kconfig > that needs them. > > Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable. > > Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UAPI") > Cc: Oleksandr Andrushchenko > Cc: Boris Ostrovsky > Cc: xen-devel@lists.xenproject.org > Cc: Juergen Gross > Cc: Stefano Stabellini > Reviewed-by: Juergen Gross > Reviewed-by: Oleksandr Andrushchenko > Signed-off-by: Jason Gunthorpe > --- > drivers/xen/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Juergen/Oleksandr/Xen Maintainers: Would you take this patch through a xen related tree? The only reason I had in this series is to make it easier to compile-test the gntdev changes. Since it is looking like the gntdev rework might not make it this cycle it is probably best for you to take it. Thanks, Jason