From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720DFC5DF62 for ; Wed, 6 Nov 2019 01:13:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 134B921D6C for ; Wed, 6 Nov 2019 01:13:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Lnltnbco" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 134B921D6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C3A1C6B0003; Tue, 5 Nov 2019 20:13:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE9DC6B0006; Tue, 5 Nov 2019 20:13:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFEFE6B0007; Tue, 5 Nov 2019 20:13:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 9B5A46B0003 for ; Tue, 5 Nov 2019 20:13:13 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 61DC5180AD80F for ; Wed, 6 Nov 2019 01:13:13 +0000 (UTC) X-FDA: 76124079066.09.waste67_736384bc92518 X-HE-Tag: waste67_736384bc92518 X-Filterd-Recvd-Size: 3246 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Nov 2019 01:13:12 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7CB1721A49; Wed, 6 Nov 2019 01:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573002791; bh=F8oZBAZiUgNBGiV+WdUohtNWYyfzETDe01QBSwwnbUE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LnltnbcoEvw0zudUzaix987ZKsj6MqDuFqsZC0+IjmxZ0XpTcoy82THWXKyrYQ0Ye mv5Z8zeYgtccYtyRipnP9TZaP3/JrnK54F4aJa9wN2ypZkOFNbFlBBd661zaIpobQL OZchQhXSAp1sAaj7ISlI/bn8Ev4MXWgPMnouR5wE= Date: Tue, 5 Nov 2019 17:13:09 -0800 From: Andrew Morton To: Mike Rapoport Cc: linux-mm@kvack.org, Anton Ivanov , Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Peter Rosin , Richard Weinberger , Rolf Eike Beer , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org, linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, sparclinux@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH v4 13/13] mm: remove __ARCH_HAS_4LEVEL_HACK and include/asm-generic/4level-fixup.h Message-Id: <20191105171309.9a5ccf9cf14d7288f7adf198@linux-foundation.org> In-Reply-To: <1572938135-31886-14-git-send-email-rppt@kernel.org> References: <1572938135-31886-1-git-send-email-rppt@kernel.org> <1572938135-31886-14-git-send-email-rppt@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 5 Nov 2019 09:15:35 +0200 Mike Rapoport wrote: > There are no architectures that use include/asm-generic/4level-fixup.h > therefore it can be removed along with __ARCH_HAS_4LEVEL_HACK define. Conflicts a bit with Vineet's "asm-generic/tlb: stub out pud_free_tlb() if nopud ...", from http://lkml.kernel.org/r/20191016162400.14796-2-vgupta@synopsys.com I fixed it up by removing include/asm-generic/4level-fixup.h anyway and removing the removal of "#ifndef __ARCH_HAS_4LEVEL_HAC" from include/asm-generic/tlb.h.