From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BACDCC5DF64 for ; Wed, 6 Nov 2019 12:04:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F7FB214D8 for ; Wed, 6 Nov 2019 12:04:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F7FB214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0E3986B0008; Wed, 6 Nov 2019 07:04:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 095066B000A; Wed, 6 Nov 2019 07:04:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F10E46B000C; Wed, 6 Nov 2019 07:04:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id D75016B0008 for ; Wed, 6 Nov 2019 07:04:04 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 66A6B8249980 for ; Wed, 6 Nov 2019 12:04:04 +0000 (UTC) X-FDA: 76125719208.17.goat21_7acbcf0d8c94f X-HE-Tag: goat21_7acbcf0d8c94f X-Filterd-Recvd-Size: 2640 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Nov 2019 12:04:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 262C8AEB3; Wed, 6 Nov 2019 12:04:02 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 0BC791E4862; Wed, 6 Nov 2019 13:04:02 +0100 (CET) Date: Wed, 6 Nov 2019 13:04:02 +0100 From: Jan Kara To: snazy@snazy.de Cc: Johannes Weiner , Vlastimil Babka , Michal Hocko , Josef Bacik , Jan Kara , "Kirill A. Shutemov" , Randy Dunlap , linux-kernel@vger.kernel.org, Linux MM , Andrew Morton , "Potyra, Stefan" Subject: Re: mlockall(MCL_CURRENT) blocking infinitely Message-ID: <20191106120402.GG16085@quack2.suse.cz> References: <707b72c6dac76c534dcce60830fa300c44f53404.camel@gmx.de> <20191025135749.GK17610@dhcp22.suse.cz> <20191025140029.GL17610@dhcp22.suse.cz> <20191105182211.GA33242@cmpxchg.org> <46c58487acc05aa3c4d5d1e72b95cd84a5dba47b.camel@gmx.de> <9072e55e97f0c4f3b286eb57639c4e9bb4223dfc.camel@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 06-11-19 12:26:24, Robert Stupp wrote: > Maybe a native and wrong idea, but would it work to call > __get_user_pages_locked() instead of __get_user_pages() in > populate_vma_page_range() ? See my reply to Johannes. It would work but it would be somewhat fragile. Honza > On Wed, 2019-11-06 at 11:25 +0100, Robert Stupp wrote: > > Here's one more dmesg output with more information captured in > > __get_user_pages() as well. It basically confirms that > > handle_mm_fault() returns VM_FAULT_RETRY. > > > > I'm not sure where and what to change ("fix with a FOLL_TRIED > > somewhere") to make it work. My (uneducated) impression is, that only > > __get_user_pages() needs to be changed - but I might be wrong. > > > -- Jan Kara SUSE Labs, CR