Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] lib/test_meminit.c: Add bulk alloc/free tests
@ 2019-11-07 19:14 Laura Abbott
  2019-11-07 21:19 ` Kees Cook
  0 siblings, 1 reply; 2+ messages in thread
From: Laura Abbott @ 2019-11-07 19:14 UTC (permalink / raw)
  To: Alexander Potapenko, Kees Cook
  Cc: Laura Abbott, Christoph Lameter, Nick Desaulniers,
	Kostya Serebryany, Dmitry Vyukov, Sandeep Patil, Jann Horn,
	Marco Elver, linux-mm, linux-kernel, Andrew Morton


kmem_cache_alloc_bulk/kmem_cache_free_bulk are used to
make multiple allocations of the same size to avoid the
overhead of multiple kmalloc/kfree calls. Extend the kmem_cache
tests to make some calls to these APIs.

Signed-off-by: Laura Abbott <labbott@redhat.com>
---
 lib/test_meminit.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/lib/test_meminit.c b/lib/test_meminit.c
index 9729f271d150..20f330948b92 100644
--- a/lib/test_meminit.c
+++ b/lib/test_meminit.c
@@ -183,6 +183,9 @@ static bool __init check_buf(void *buf, int size, bool want_ctor,
 	return fail;
 }
 
+#define BULK_SIZE 100
+static void *bulk_array[BULK_SIZE];
+
 /*
  * Test kmem_cache with given parameters:
  *  want_ctor - use a constructor;
@@ -203,9 +206,24 @@ static int __init do_kmem_cache_size(size_t size, bool want_ctor,
 			      want_rcu ? SLAB_TYPESAFE_BY_RCU : 0,
 			      want_ctor ? test_ctor : NULL);
 	for (iter = 0; iter < 10; iter++) {
+		/* Do a test of bulk allocations */
+		if (!want_rcu && !want_ctor) {
+			int ret;
+
+			ret = kmem_cache_alloc_bulk(c, alloc_mask, BULK_SIZE, bulk_array);
+			if (!ret) {
+				fail = true;
+			} else {
+				int i;
+				for (i = 0; i < ret; i++)
+					fail |= check_buf(bulk_array[i], size, want_ctor, want_rcu, want_zero);
+				kmem_cache_free_bulk(c, ret, bulk_array);
+			}
+		}
+
 		buf = kmem_cache_alloc(c, alloc_mask);
 		/* Check that buf is zeroed, if it must be. */
-		fail = check_buf(buf, size, want_ctor, want_rcu, want_zero);
+		fail |= check_buf(buf, size, want_ctor, want_rcu, want_zero);
 		fill_with_garbage_skip(buf, size, want_ctor ? CTOR_BYTES : 0);
 
 		if (!want_rcu) {
-- 
2.21.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] lib/test_meminit.c: Add bulk alloc/free tests
  2019-11-07 19:14 [PATCH] lib/test_meminit.c: Add bulk alloc/free tests Laura Abbott
@ 2019-11-07 21:19 ` Kees Cook
  0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2019-11-07 21:19 UTC (permalink / raw)
  To: Laura Abbott
  Cc: Alexander Potapenko, Christoph Lameter, Nick Desaulniers,
	Kostya Serebryany, Dmitry Vyukov, Sandeep Patil, Jann Horn,
	Marco Elver, linux-mm, linux-kernel, Andrew Morton

On Thu, Nov 07, 2019 at 02:14:47PM -0500, Laura Abbott wrote:
> 
> kmem_cache_alloc_bulk/kmem_cache_free_bulk are used to
> make multiple allocations of the same size to avoid the
> overhead of multiple kmalloc/kfree calls. Extend the kmem_cache
> tests to make some calls to these APIs.
> 
> Signed-off-by: Laura Abbott <labbott@redhat.com>

Thanks! Andrew, can you add this to -mm please?

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  lib/test_meminit.c | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/test_meminit.c b/lib/test_meminit.c
> index 9729f271d150..20f330948b92 100644
> --- a/lib/test_meminit.c
> +++ b/lib/test_meminit.c
> @@ -183,6 +183,9 @@ static bool __init check_buf(void *buf, int size, bool want_ctor,
>  	return fail;
>  }
>  
> +#define BULK_SIZE 100
> +static void *bulk_array[BULK_SIZE];
> +
>  /*
>   * Test kmem_cache with given parameters:
>   *  want_ctor - use a constructor;
> @@ -203,9 +206,24 @@ static int __init do_kmem_cache_size(size_t size, bool want_ctor,
>  			      want_rcu ? SLAB_TYPESAFE_BY_RCU : 0,
>  			      want_ctor ? test_ctor : NULL);
>  	for (iter = 0; iter < 10; iter++) {
> +		/* Do a test of bulk allocations */
> +		if (!want_rcu && !want_ctor) {
> +			int ret;
> +
> +			ret = kmem_cache_alloc_bulk(c, alloc_mask, BULK_SIZE, bulk_array);
> +			if (!ret) {
> +				fail = true;
> +			} else {
> +				int i;
> +				for (i = 0; i < ret; i++)
> +					fail |= check_buf(bulk_array[i], size, want_ctor, want_rcu, want_zero);
> +				kmem_cache_free_bulk(c, ret, bulk_array);
> +			}
> +		}
> +
>  		buf = kmem_cache_alloc(c, alloc_mask);
>  		/* Check that buf is zeroed, if it must be. */
> -		fail = check_buf(buf, size, want_ctor, want_rcu, want_zero);
> +		fail |= check_buf(buf, size, want_ctor, want_rcu, want_zero);
>  		fill_with_garbage_skip(buf, size, want_ctor ? CTOR_BYTES : 0);
>  
>  		if (!want_rcu) {
> -- 
> 2.21.0
> 

-- 
Kees Cook


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 19:14 [PATCH] lib/test_meminit.c: Add bulk alloc/free tests Laura Abbott
2019-11-07 21:19 ` Kees Cook

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git