From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA2AEC43331 for ; Mon, 11 Nov 2019 10:12:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 954F121783 for ; Mon, 11 Nov 2019 10:12:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 954F121783 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 395766B0006; Mon, 11 Nov 2019 05:12:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 345826B0007; Mon, 11 Nov 2019 05:12:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25BDB6B0008; Mon, 11 Nov 2019 05:12:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id 121126B0006 for ; Mon, 11 Nov 2019 05:12:52 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id B06A9180AD81F for ; Mon, 11 Nov 2019 10:12:51 +0000 (UTC) X-FDA: 76143582942.28.box05_18efee0cc7906 X-HE-Tag: box05_18efee0cc7906 X-Filterd-Recvd-Size: 1522 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Nov 2019 10:12:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 853F2B29C; Mon, 11 Nov 2019 10:12:49 +0000 (UTC) Date: Mon, 11 Nov 2019 11:12:48 +0100 From: Michal Hocko To: Qian Cai Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, guro@fb.com, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm/vmscan: fix an undefined behavior for zone id Message-ID: <20191111101248.GF1396@dhcp22.suse.cz> References: <20191108204407.1435-1-cai@lca.pw> <64E60F6F-7582-427B-8DD5-EF97B1656F5A@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64E60F6F-7582-427B-8DD5-EF97B1656F5A@lca.pw> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000212, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 08-11-19 16:26:52, Qian Cai wrote: > > > > On Nov 8, 2019, at 3:44 PM, Qian Cai wrote: > > > > - for (zid = 0; zid <= zone_idx; zid++) { > > + for (zid = 0; zid < zone_idx; zid++) { > > struct zone *zone = > > Oops, I think here needs to be, > > for (zid = 0; zid <= zone_idx && zid < MAX_NR_ZONES; zid++) { > > to deal with this MAX_NR_ZONES special case. Yep this looks correct. Thanks! -- Michal Hocko SUSE Labs