From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17AA9C17441 for ; Mon, 11 Nov 2019 23:39:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD57C21925 for ; Mon, 11 Nov 2019 23:39:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HE5NIfwe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD57C21925 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6DD3E6B0006; Mon, 11 Nov 2019 18:39:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 666696B0007; Mon, 11 Nov 2019 18:39:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 555CC6B0008; Mon, 11 Nov 2019 18:39:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id 3B5BE6B0006 for ; Mon, 11 Nov 2019 18:39:34 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id C5D97181AC9CC for ; Mon, 11 Nov 2019 23:39:33 +0000 (UTC) X-FDA: 76145615826.21.twig99_53740e464a15e X-HE-Tag: twig99_53740e464a15e X-Filterd-Recvd-Size: 2915 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Nov 2019 23:39:33 +0000 (UTC) Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 387A3214DB; Mon, 11 Nov 2019 23:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573515572; bh=giENcYoxNX1U3BVpJL1kOu9YRWXh/5mhELyr0r5TYJM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HE5NIfwe5GY7DfSwk8ze/X5zVp8IQcxUPElx2TZeg4Tv2iW5Tns2MCmOoxbCLN21b rMqFg+EiT5ZzKgUdyEwteLODj92Da4xGPsS0yyZ1fG+xzO8+k/HfTuw2FnaI2y3OTl eIhNmOepWnUnSIOgk0gXIVqjHTVWYwCZWw2ZYHxc= Date: Mon, 11 Nov 2019 15:39:31 -0800 From: Andrew Morton To: "Maciej S. Szmigiero" Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] zswap: allow setting default status, compressor and allocator in Kconfig Message-Id: <20191111153931.199e4c729bfad2e8201e75a5@linux-foundation.org> In-Reply-To: <20191108235107.2837339-1-mail@maciej.szmigiero.name> References: <20191108235107.2837339-1-mail@maciej.szmigiero.name> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 9 Nov 2019 00:51:07 +0100 "Maciej S. Szmigiero" wrote: > The compressed cache for swap pages (zswap) currently needs from 1 to 3 > extra kernel command line parameters in order to make it work: it has to be > enabled by adding a "zswap.enabled=1" command line parameter and if one > wants a different compressor or pool allocator than the default lzo / zbud > combination then these choices also need to be specified on the kernel > command line in additional parameters. > > Using a different compressor and allocator for zswap is actually pretty > common as guides often recommend using the lz4 / z3fold pair instead of > the default one. > In such case it is also necessary to remember to enable the appropriate > compression algorithm and pool allocator in the kernel config manually. > > Let's avoid the need for adding these kernel command line parameters and > automatically pull in the dependencies for the selected compressor > algorithm and pool allocator by adding an appropriate default switches to > Kconfig. > > The default values for these options match what the code was using > previously as its defaults. Shouldn't there be a Documentation/ update along with this change?