From: Shile Zhang <shile.zhang@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Joerg Roedel <jroedel@suse.de>
Cc: linux-mm@kvack.org, linux-kbuild@vger.kernel.org,
Shile Zhang <shile.zhang@linux.alibaba.com>
Subject: [PATCH] mm/vmalloc: Fix regression caused by needless vmalloc_sync_all()
Date: Wed, 13 Nov 2019 17:55:30 +0800 [thread overview]
Message-ID: <20191113095530.228959-1-shile.zhang@linux.alibaba.com> (raw)
vmalloc_sync_all() was put in the common path in
__purge_vmap_area_lazy(), for one sync issue only happened on X86_32
with PTI enabled. It is needless for X86_64, which caused a big regression
in UnixBench Shell8 testing on X86_64.
Similar regression also reported by 0-day kernel test robot in reaim
benchmarking:
https://lists.01.org/hyperkitty/list/lkp@lists.01.org/thread/4D3JPPHBNOSPFK2KEPC6KGKS6J25AIDB/
Fix it by adding more conditions.
Fixes: 3f8fd02b1bf1 ("mm/vmalloc: Sync unmappings in __purge_vmap_area_lazy()")
Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
---
mm/vmalloc.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index a3c70e275f4e..7b9fc7966da6 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1255,11 +1255,17 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)
if (unlikely(valist == NULL))
return false;
+#if defined(CONFIG_X86_32) && defined(CONFIG_X86_PAE)
/*
* First make sure the mappings are removed from all page-tables
* before they are freed.
+ *
+ * This is only needed on x86-32 with !SHARED_KERNEL_PMD, which is
+ * the case on a PAE kernel with PTI enabled.
*/
- vmalloc_sync_all();
+ if (!SHARED_KERNEL_PMD && boot_cpu_has(X86_FEATURE_PTI))
+ vmalloc_sync_all();
+#endif
/*
* TODO: to calculate a flush range without looping.
--
2.24.0.rc2
next reply other threads:[~2019-11-13 9:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 9:55 Shile Zhang [this message]
2019-11-13 15:17 ` [PATCH] mm/vmalloc: Fix regression caused by needless vmalloc_sync_all() Qian Cai
2019-11-13 21:12 ` Andrew Morton
2019-11-14 0:54 ` Shile Zhang
2019-11-14 13:56 ` Michal Hocko
2019-11-14 14:40 ` Shile Zhang
2019-11-14 17:14 ` Joerg Roedel
2019-11-14 17:12 ` Joerg Roedel
2019-11-15 0:01 ` Andrew Morton
2019-11-15 8:38 ` Borislav Petkov
2019-11-15 23:37 ` Andrew Morton
2019-11-16 17:38 ` Borislav Petkov
2019-11-15 1:06 ` Shile Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113095530.228959-1-shile.zhang@linux.alibaba.com \
--to=shile.zhang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).