From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19DBFC432C3 for ; Sat, 16 Nov 2019 17:38:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B1A312168B for ; Sat, 16 Nov 2019 17:38:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="qk54/MLn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1A312168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 153EF6B0279; Sat, 16 Nov 2019 12:38:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 105476B027A; Sat, 16 Nov 2019 12:38:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01A536B027B; Sat, 16 Nov 2019 12:38:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id DFF036B0279 for ; Sat, 16 Nov 2019 12:38:28 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 95DE1180AD80F for ; Sat, 16 Nov 2019 17:38:28 +0000 (UTC) X-FDA: 76162849896.12.north85_84185716b5e2c X-HE-Tag: north85_84185716b5e2c X-Filterd-Recvd-Size: 3206 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Nov 2019 17:38:27 +0000 (UTC) Received: from zn.tnic (p200300EC2F1E69004D402704569CB5C2.dip0.t-ipconnect.de [IPv6:2003:ec:2f1e:6900:4d40:2704:569c:b5c2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8E19B1EC0C5C; Sat, 16 Nov 2019 18:38:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1573925905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=YfjgNcXzrwa9FczNGoC3Ua0nKx+rjkktYHqZA/58SbI=; b=qk54/MLnu+jWK90BzXd2Xb4kThbk+kqZ22YmHfkH4nfiFLBCRjaGao8nK07n/nNZXp+Y1r rIig5w/0NneAhQDICAznzyTZ72UKkUhS8chjnQY5RHvnymQT5sEcGP8hb/pIXRMvEafu59 FQJr5H7qtTekvl29M08IPY1gyuOZ/1M= Date: Sat, 16 Nov 2019 18:38:20 +0100 From: Borislav Petkov To: Andrew Morton Cc: Joerg Roedel , Shile Zhang , linux-mm@kvack.org, linux-kbuild@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , hpa@zytor.com Subject: Re: [PATCH] mm/vmalloc: Fix regression caused by needless vmalloc_sync_all() Message-ID: <20191116173820.GB23231@zn.tnic> References: <20191113095530.228959-1-shile.zhang@linux.alibaba.com> <20191114171231.GA21753@suse.de> <20191114160108.57a72907f7b1aa9860471a06@linux-foundation.org> <20191115083847.GB18929@zn.tnic> <20191115153721.c869afe6e7564877b848c69d@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191115153721.c869afe6e7564877b848c69d@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 15, 2019 at 03:37:21PM -0800, Andrew Morton wrote: > OK, thanks, here's what I queued. Reviews, acks and testing, please?? > > From: Joerg Roedel > Subject: x86/mm: Split vmalloc_sync_all() > > Commit 3f8fd02b1bf1 ("mm/vmalloc: Sync unmappings in > __purge_vmap_area_lazy()") introduced a call to vmalloc_sync_all() in the > vunmap() code-path. While this change was necessary to maintain > correctness on x86-32-pae kernels, it also adds additional cycles for > architectures that don't need it. ... > arch/x86/mm/fault.c | 26 ++++++++++++++++++++++++-- > drivers/acpi/apei/ghes.c | 2 +- > include/linux/vmalloc.h | 5 +++-- > kernel/notifier.c | 2 +- > mm/nommu.c | 10 +++++++--- > mm/vmalloc.c | 11 +++++++---- > 6 files changed, 43 insertions(+), 13 deletions(-) Booting it looks ok here: Tested-by: Borislav Petkov -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette