From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Rafael Aquini <aquini@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: kconfig: make Transparent Hugepage Support sysfs defaults to match the documentation
Date: Tue, 19 Nov 2019 13:47:41 +0300 [thread overview]
Message-ID: <20191119104741.rtjc7awl4k57boyu@box> (raw)
In-Reply-To: <20191119030102.27559-1-aquini@redhat.com>
On Mon, Nov 18, 2019 at 10:01:02PM -0500, Rafael Aquini wrote:
> Documentation/admin-guide/mm/transhuge.rst (originally in Documentation/vm/transhuge.txt)
> states that TRANSPARENT_HUGEPAGE_MADVISE is the default option for THP config:
>
> "
> madvise
> will enter direct reclaim like ``always`` but only for regions
> that are have used madvise(MADV_HUGEPAGE). This is the default
> behaviour.
> "
>
> This patch changes mm/Kconfig to reflect that fact, accordingly.
No. You've read it incorrectly.
The documentation describes default behaviour wrt defragmentaton ("defrag"
file), not page fault ("enabled" file). We don't have any Kconfig option
to set default behaviour for "defrag".
> Besides keeping consistency between documentation and the code behavior,
> other reasons to perform this minor adjustment are noted at:
> https://bugzilla.redhat.com/show_bug.cgi?id=1772133
>
> Signed-off-by: Rafael Aquini <aquini@redhat.com>
> ---
> mm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index a5dae9a7eb51..c12a559aa1e5 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -385,7 +385,7 @@ config TRANSPARENT_HUGEPAGE
> choice
> prompt "Transparent Hugepage Support sysfs defaults"
> depends on TRANSPARENT_HUGEPAGE
> - default TRANSPARENT_HUGEPAGE_ALWAYS
> + default TRANSPARENT_HUGEPAGE_MADVISE
> help
> Selects the sysfs defaults for Transparent Hugepage Support.
>
> --
> 2.17.2
>
>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2019-11-19 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 3:01 [PATCH] mm: kconfig: make Transparent Hugepage Support sysfs defaults to match the documentation Rafael Aquini
2019-11-19 10:47 ` Kirill A. Shutemov [this message]
2019-11-19 14:58 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119104741.rtjc7awl4k57boyu@box \
--to=kirill@shutemov.name \
--cc=aquini@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).