From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEBFCC432C0 for ; Thu, 21 Nov 2019 08:09:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 835F720855 for ; Thu, 21 Nov 2019 08:09:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="N98XJ+wQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 835F720855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 392906B02ED; Thu, 21 Nov 2019 03:09:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 341D46B02EE; Thu, 21 Nov 2019 03:09:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 231F36B02EF; Thu, 21 Nov 2019 03:09:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 08CD96B02ED for ; Thu, 21 Nov 2019 03:09:54 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id BCDB24DA9 for ; Thu, 21 Nov 2019 08:09:53 +0000 (UTC) X-FDA: 76179561066.13.tin08_7370d506ee645 X-HE-Tag: tin08_7370d506ee645 X-Filterd-Recvd-Size: 3896 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Nov 2019 08:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DswBTpSaicVa5QbsMs/ANPkwqvOsaFkY8F3EdUoQjkg=; b=N98XJ+wQLrOE0PETm4zBlbOK/ uNBH0YI/AtQmzRFUrrNmsInAFqqCUqf7aGnDvhqflZGROduSEmu+qKChu1bZWcfYuqimCGzp7hDzs iCjpAjiPKC/Ai1Gb4oDEmbTBm48pEn/ADisr9dWUw4asaPTODXhiPfdUNT5C739Gi/3F6OMTHMIlx 2FFXE/Pe7niX/m1UrQ8r/sJL88siL40CeOUl7arbNQeiLfhtsv1Og92J+cwHlZmrgznfEWdywDG/8 M26yLaMEfP+B52OW9Fidvb4pjlbfAUqocGCTLzTzDi3u5jzKqdTurIm3N21xYHtrwJTojSYCjyez7 yMUzcHFXg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXhVC-0008Cg-4Q; Thu, 21 Nov 2019 08:07:46 +0000 Date: Thu, 21 Nov 2019 00:07:46 -0800 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML , Jason Gunthorpe Subject: Re: [PATCH v7 07/24] IB/umem: use get_user_pages_fast() to pin DMA pages Message-ID: <20191121080746.GC30991@infradead.org> References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-8-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121071354.456618-8-jhubbard@nvidia.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 20, 2019 at 11:13:37PM -0800, John Hubbard wrote: > And get rid of the mmap_sem calls, as part of that. Note > that get_user_pages_fast() will, if necessary, fall back to > __gup_longterm_unlocked(), which takes the mmap_sem as needed. > > Reviewed-by: Jan Kara > Reviewed-by: Jason Gunthorpe > Reviewed-by: Ira Weiny > Signed-off-by: John Hubbard Looks fine, Reviewed-by: Christoph Hellwig Jason, can you queue this up for 5.5 to reduce this patch stack a bit?