From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77C0EC43215 for ; Thu, 21 Nov 2019 15:20:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 45A822071F for ; Thu, 21 Nov 2019 15:20:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45A822071F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.page Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC14E6B0326; Thu, 21 Nov 2019 10:20:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D715B6B0327; Thu, 21 Nov 2019 10:20:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C86CF6B0328; Thu, 21 Nov 2019 10:20:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id AD2476B0326 for ; Thu, 21 Nov 2019 10:20:00 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 718142AAE for ; Thu, 21 Nov 2019 15:20:00 +0000 (UTC) X-FDA: 76180644960.20.day31_573fecffa154c X-HE-Tag: day31_573fecffa154c X-Filterd-Recvd-Size: 2450 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Nov 2019 15:19:59 +0000 (UTC) X-Originating-IP: 153.3.140.100 Received: from localhost.localdomain.localdomain (unknown [153.3.140.100]) (Authenticated sender: fly@kernel.page) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 390EE1C000A; Thu, 21 Nov 2019 15:19:47 +0000 (UTC) From: Pengfei Li To: akpm@linux-foundation.org Cc: mgorman@techsingularity.net, mhocko@kernel.org, vbabka@suse.cz, cl@linux.com, iamjoonsoo.kim@lge.com, guro@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pengfei Li Subject: [RFC v1 02/19] mm, hugetlb: use for_each_node in dequeue_huge_page_nodemask() Date: Thu, 21 Nov 2019 23:17:54 +0800 Message-Id: <20191121151811.49742-3-fly@kernel.page> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191121151811.49742-1-fly@kernel.page> References: <20191121151811.49742-1-fly@kernel.page> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In dequeue_huge_page_nodemask(), we want to traverse node instead of zone, so use for_each_node instead of for_each_zone. Signed-off-by: Pengfei Li --- mm/hugetlb.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 2e55ec5dc84d..287b90c7ab36 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -850,25 +850,18 @@ static struct page *dequeue_huge_page_nodemask(stru= ct hstate *h, gfp_t gfp_mask, unsigned int cpuset_mems_cookie; struct nodelist *nodelist; struct nlist_traverser t; - struct zone *zone; - int node =3D NUMA_NO_NODE; + int node; =20 nodelist =3D node_nodelist(nid, gfp_mask); =20 retry_cpuset: cpuset_mems_cookie =3D read_mems_allowed_begin(); - for_each_zone_nlist_nodemask(zone, &t, nodelist, gfp_zone(gfp_mask), nm= ask) { + for_each_node_nlist_nodemask(node, &t, nodelist, + gfp_zone(gfp_mask), nmask) { struct page *page; =20 - if (!cpuset_zone_allowed(zone, gfp_mask)) - continue; - /* - * no need to ask again on the same node. Pool is node rather than - * zone aware - */ - if (zone_to_nid(zone) =3D=3D node) + if (!cpuset_node_allowed(node, gfp_mask)) continue; - node =3D zone_to_nid(zone); =20 page =3D dequeue_huge_page_node_exact(h, node); if (page) --=20 2.23.0