From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82EC6C432C0 for ; Sun, 1 Dec 2019 01:50:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 377F92086A for ; Sun, 1 Dec 2019 01:50:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="N+CZlBWK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 377F92086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC2E86B0294; Sat, 30 Nov 2019 20:50:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D73426B0296; Sat, 30 Nov 2019 20:50:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C88DD6B0297; Sat, 30 Nov 2019 20:50:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id AF04A6B0294 for ; Sat, 30 Nov 2019 20:50:48 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 658E8180AD817 for ; Sun, 1 Dec 2019 01:50:48 +0000 (UTC) X-FDA: 76214893776.25.elbow50_701eec72f300 X-HE-Tag: elbow50_701eec72f300 X-Filterd-Recvd-Size: 2867 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Dec 2019 01:50:48 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F2C8208E4; Sun, 1 Dec 2019 01:50:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575165047; bh=WYPcX9zTkbpFT93PVsZfKpohbxeZdoKh1Ucj0kHGlvA=; h=Date:From:To:Subject:From; b=N+CZlBWKmkfy9mHUdkbC7p2qnGffNN/qbOy2dK3uzyUXlecyL1IBRdoT4PxSzp8O8 WMJBGzLU4djZn/hzibgxdm9SUIgPbWwdURu+bB4t7zwcKuVwzjVFakzCdeE010w7SW 4Nr1o1IZCTSWvFYoiu7l9rTbQizeyR7IcJbrtkpA= Date: Sat, 30 Nov 2019 17:50:46 -0800 From: akpm@linux-foundation.org To: akpm@linux-foundation.org, hch@infradead.org, linux-mm@kvack.org, mgorman@techsingularity.net, mm-commits@vger.kernel.org, osalvador@suse.de, richardw.yang@linux.intel.com, torvalds@linux-foundation.org, vbabka@suse.cz, willy@infradead.org Subject: [patch 031/158] mm/mmap.c: __vma_unlink_prev() is not necessary now Message-ID: <20191201015046.7koFRsYYb%akpm@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Wei Yang Subject: mm/mmap.c: __vma_unlink_prev() is not necessary now The third parameter of __vma_unlink_common() could differentiate these two types. __vma_unlink_prev() is not necessary now. Link: http://lkml.kernel.org/r/20191006012636.31521-2-richardw.yang@linux.intel.com Signed-off-by: Wei Yang Cc: Christoph Hellwig Cc: Matthew Wilcox (Oracle) Cc: Mel Gorman Cc: Oscar Salvador Cc: Vlastimil Babka Signed-off-by: Andrew Morton --- mm/mmap.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) --- a/mm/mmap.c~mm-mmapc-__vma_unlink_prev-is-not-necessary-now +++ a/mm/mmap.c @@ -702,13 +702,6 @@ static __always_inline void __vma_unlink vmacache_invalidate(mm); } -static inline void __vma_unlink_prev(struct mm_struct *mm, - struct vm_area_struct *vma, - struct vm_area_struct *prev) -{ - __vma_unlink_common(mm, vma, vma); -} - /* * We cannot adjust vm_start, vm_end, vm_pgoff fields of a vma that * is already present in an i_mmap tree without adjusting the tree. @@ -881,7 +874,7 @@ again: * us to remove next before dropping the locks. */ if (remove_next != 3) - __vma_unlink_prev(mm, next, vma); + __vma_unlink_common(mm, next, next); else /* * vma is not before next if they've been _