From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D451C432C0 for ; Sun, 1 Dec 2019 01:50:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C7F67206F0 for ; Sun, 1 Dec 2019 01:50:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gYE+/12Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7F67206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 780E76B0298; Sat, 30 Nov 2019 20:50:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 730F26B029A; Sat, 30 Nov 2019 20:50:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F9A06B029B; Sat, 30 Nov 2019 20:50:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id 47CA06B0298 for ; Sat, 30 Nov 2019 20:50:55 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 02843180AD817 for ; Sun, 1 Dec 2019 01:50:55 +0000 (UTC) X-FDA: 76214894070.27.verse90_7f64042a4058 X-HE-Tag: verse90_7f64042a4058 X-Filterd-Recvd-Size: 4144 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Dec 2019 01:50:54 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 855292073C; Sun, 1 Dec 2019 01:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575165053; bh=dSnhQ39iU0lth5tK/Nzm9cXeYscgXQH+T9+A/REhXhc=; h=Date:From:To:Subject:From; b=gYE+/12YDsTB850cc6J7MSL7TNKOZyow6Dv0EwScbqSSnYM9e+T6Quf8Gs/HbjSQs tfTf06+ljuyD9JN3+Taq0nlWIKI83CRdIjgT5gL6uWrMEUv1BV7RfL5wHhVrMLzNbo VV1O+43yINyibfEMEdOznMeb3DUdbAuf3xhW1tps= Date: Sat, 30 Nov 2019 17:50:53 -0800 From: akpm@linux-foundation.org To: akpm@linux-foundation.org, linux-mm@kvack.org, mgorman@techsingularity.net, mm-commits@vger.kernel.org, richardw.yang@linux.intel.com, torvalds@linux-foundation.org, vbabka@suse.cz, willy@infradead.org Subject: [patch 033/158] mm/mmap.c: rb_parent is not necessary in __vma_link_list() Message-ID: <20191201015053.yBGUELT9h%akpm@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Wei Yang Subject: mm/mmap.c: rb_parent is not necessary in __vma_link_list() Now we use rb_parent to get next, while this is not necessary. When prev is NULL, this means vma should be the first element in the list. Then next should be current first one (mm->mmap), no matter whether we have parent or not. After removing it, the code shows the beauty of symmetry. Link: http://lkml.kernel.org/r/20190813032656.16625-1-richardw.yang@linux.intel.com Signed-off-by: Wei Yang Acked-by: Andrew Morton Cc: Mel Gorman Cc: Vlastimil Babka Cc: Matthew Wilcox Signed-off-by: Andrew Morton --- mm/internal.h | 2 +- mm/mmap.c | 2 +- mm/nommu.c | 2 +- mm/util.c | 8 ++------ 4 files changed, 5 insertions(+), 9 deletions(-) --- a/mm/internal.h~mm-mmapc-rb_parent-is-not-necessary-in-__vma_link_list +++ a/mm/internal.h @@ -290,7 +290,7 @@ static inline bool is_data_mapping(vm_fl /* mm/util.c */ void __vma_link_list(struct mm_struct *mm, struct vm_area_struct *vma, - struct vm_area_struct *prev, struct rb_node *rb_parent); + struct vm_area_struct *prev); void __vma_unlink_list(struct mm_struct *mm, struct vm_area_struct *vma); #ifdef CONFIG_MMU --- a/mm/mmap.c~mm-mmapc-rb_parent-is-not-necessary-in-__vma_link_list +++ a/mm/mmap.c @@ -641,7 +641,7 @@ __vma_link(struct mm_struct *mm, struct struct vm_area_struct *prev, struct rb_node **rb_link, struct rb_node *rb_parent) { - __vma_link_list(mm, vma, prev, rb_parent); + __vma_link_list(mm, vma, prev); __vma_link_rb(mm, vma, rb_link, rb_parent); } --- a/mm/nommu.c~mm-mmapc-rb_parent-is-not-necessary-in-__vma_link_list +++ a/mm/nommu.c @@ -648,7 +648,7 @@ static void add_vma_to_mm(struct mm_stru if (rb_prev) prev = rb_entry(rb_prev, struct vm_area_struct, vm_rb); - __vma_link_list(mm, vma, prev, parent); + __vma_link_list(mm, vma, prev); } /* --- a/mm/util.c~mm-mmapc-rb_parent-is-not-necessary-in-__vma_link_list +++ a/mm/util.c @@ -271,7 +271,7 @@ void *memdup_user_nul(const void __user EXPORT_SYMBOL(memdup_user_nul); void __vma_link_list(struct mm_struct *mm, struct vm_area_struct *vma, - struct vm_area_struct *prev, struct rb_node *rb_parent) + struct vm_area_struct *prev) { struct vm_area_struct *next; @@ -280,12 +280,8 @@ void __vma_link_list(struct mm_struct *m next = prev->vm_next; prev->vm_next = vma; } else { + next = mm->mmap; mm->mmap = vma; - if (rb_parent) - next = rb_entry(rb_parent, - struct vm_area_struct, vm_rb); - else - next = NULL; } vma->vm_next = next; if (next) _