From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BACCC432C0 for ; Sun, 1 Dec 2019 01:58:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 220D6208C3 for ; Sun, 1 Dec 2019 01:58:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bdvTpLHB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 220D6208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C37676B0392; Sat, 30 Nov 2019 20:58:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE6886B0394; Sat, 30 Nov 2019 20:58:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFEBE6B0395; Sat, 30 Nov 2019 20:58:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 984AF6B0392 for ; Sat, 30 Nov 2019 20:58:06 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 54825824999B for ; Sun, 1 Dec 2019 01:58:06 +0000 (UTC) X-FDA: 76214912172.05.hour82_46bc0753da261 X-HE-Tag: hour82_46bc0753da261 X-Filterd-Recvd-Size: 2510 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Dec 2019 01:58:05 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 34A34215F1; Sun, 1 Dec 2019 01:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575165485; bh=G5CtEnc8ux9RHPf8KNnC8NrhnXVfQXVgYPJn7u3kcOo=; h=Date:From:To:Subject:From; b=bdvTpLHB6/AkV+l2PKjbAZXaig6/yGy5asxjc0W3x7ubKd7jKRuKjaQCK2O4nXSNv f27kAlPaFOqySzXTwntx9o2KtBmkRWS/PnNgwfwadxwMZFdXyE2xrEwMsX03Kk+GqK uiJIoNVzMjhtZVMFUNwrshZJ8ZOkbl3RbaJ8KwVQ= Date: Sat, 30 Nov 2019 17:58:04 -0800 From: akpm@linux-foundation.org To: akpm@linux-foundation.org, colin.king@canonical.com, hughd@google.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 150/158] mm/shmem.c: make array 'values' static const, makes object smaller Message-ID: <20191201015804.qRDuXlQiq%akpm@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Colin Ian King Subject: mm/shmem.c: make array 'values' static const, makes object smaller Don't populate the array 'values' on the stack but instead make it static const. Makes the object code smaller by 111 bytes. Before: text data bss dec hex filename 108612 11169 512 120293 1d5e5 mm/shmem.o After: text data bss dec hex filename 108437 11233 512 120182 1d576 mm/shmem.o (gcc version 9.2.1, amd64) Link: http://lkml.kernel.org/r/20190906143012.28698-1-colin.king@canonical.com Signed-off-by: Colin Ian King Reviewed-by: Andrew Morton Cc: Hugh Dickins Signed-off-by: Andrew Morton --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/shmem.c~mm-shmemc-make-array-values-static-const-makes-object-smaller +++ a/mm/shmem.c @@ -3932,7 +3932,7 @@ out2: static ssize_t shmem_enabled_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { - int values[] = { + static const int values[] = { SHMEM_HUGE_ALWAYS, SHMEM_HUGE_WITHIN_SIZE, SHMEM_HUGE_ADVISE, _