From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D34C3F68F for ; Wed, 4 Dec 2019 14:35:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8F8A420675 for ; Wed, 4 Dec 2019 14:35:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F8A420675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25D356B0B0C; Wed, 4 Dec 2019 09:35:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 20E5E6B0B0D; Wed, 4 Dec 2019 09:35:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FD566B0B0E; Wed, 4 Dec 2019 09:35:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id E9D016B0B0C for ; Wed, 4 Dec 2019 09:35:24 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id A1DED8016AB1 for ; Wed, 4 Dec 2019 14:35:24 +0000 (UTC) X-FDA: 76227706968.23.nose80_121595685340d X-HE-Tag: nose80_121595685340d X-Filterd-Recvd-Size: 4982 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Dec 2019 14:35:24 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id z7so8805296wrl.13 for ; Wed, 04 Dec 2019 06:35:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=COMExwvouadcQjAZ+j/aoCpf/bM+m1P6K6pubVfD2Hg=; b=QgaLXxgmSCRpFRETfR4OBBckabBKZeYC5MJMw2HY6ZqVDX4/hEQZBNK7fpDZt8AK70 DA41AuVaXDw4fYeqex/2RU5kaaqKHVWvJP69eoawVwHEdg6Z+nOX70ZMZH8r6kowSqFE UAwwXaJRcsXi4sDYJm5hPELnLJIfvWYCMfKLTnDI8Pw7ZIDGdvm54qJkTH/ndoyAP5mI 8UwjgdJ3g/62SNwPqNzhQtuxa8lUpVLVn2bDCmcTjNRqgQzqbjb3Ul6e8O7xtqCBT9I1 E8gzsLKXizQhIT+oE29399mLQokMtsqsNevv41Br6/UncCXnM23+4nozRO8e4DrXoQoA 27aQ== X-Gm-Message-State: APjAAAX/f5dm0MyDnPYB2OyCJt+WJJsl0FR4X38Hx0d2Z9ZHqUsS0wWD ii5EfndbuEEffxgetsTIObk= X-Google-Smtp-Source: APXvYqynBtkN+xmFaa6Ak9kWrzD46VfMxjzOkttwtuEbyf5iK06e03rFUEc6Ktv51sFARz/ZAj3Hxw== X-Received: by 2002:a5d:4807:: with SMTP id l7mr4541406wrq.64.1575470122948; Wed, 04 Dec 2019 06:35:22 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id y139sm7286535wmd.24.2019.12.04.06.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 06:35:21 -0800 (PST) Date: Wed, 4 Dec 2019 15:35:21 +0100 From: Michal Hocko To: Thomas =?iso-8859-1?Q?Hellstr=F6m_=28VMware=29?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pv-drivers@vmware.com, linux-graphics-maintainer@vmware.com, Thomas Hellstrom , Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Ralph Campbell , =?iso-8859-1?B?Suly9G1l?= Glisse , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH v2 2/2] drm/ttm: Fix vm page protection handling Message-ID: <20191204143521.GJ25242@dhcp22.suse.cz> References: <20191203104853.4378-1-thomas_os@shipmail.org> <20191203104853.4378-3-thomas_os@shipmail.org> <20191204135219.GH25242@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 04-12-19 15:16:09, Thomas Hellstr=F6m (VMware) wrote: > On 12/4/19 2:52 PM, Michal Hocko wrote: > > On Tue 03-12-19 11:48:53, Thomas Hellstr=F6m (VMware) wrote: > > > From: Thomas Hellstrom > > >=20 > > > TTM graphics buffer objects may, transparently to user-space, move > > > between IO and system memory. When that happens, all PTEs pointing = to the > > > old location are zapped before the move and then faulted in again i= f > > > needed. When that happens, the page protection caching mode- and > > > encryption bits may change and be different from those of > > > struct vm_area_struct::vm_page_prot. > > >=20 > > > We were using an ugly hack to set the page protection correctly. > > > Fix that and instead use vmf_insert_mixed_prot() and / or > > > vmf_insert_pfn_prot(). > > > Also get the default page protection from > > > struct vm_area_struct::vm_page_prot rather than using vm_get_page_p= rot(). > > > This way we catch modifications done by the vm system for drivers t= hat > > > want write-notification. > > So essentially this should have any new side effect on functionality = it > > is just making a hacky/ugly code less so? >=20 > Functionality is unchanged. The use of a on-stack vma copy was severely > frowned upon in an earlier thread, which also points to another similar > example using vmf_insert_pfn_prot(). >=20 > https://lore.kernel.org/lkml/20190905103541.4161-2-thomas_os@shipmail.o= rg/ >=20 > > In other words what are the > > consequences of having page protection inconsistent from vma's? >=20 > During the years, it looks like the caching- and encryption flags of > vma::vm_page_prot have been largely removed from usage. From what I can > tell, there are no more places left that can affect TTM. We discussed > __split_huge_pmd_locked() towards the end of that thread, but that does= n't > affect TTM even with huge page-table entries. Please state all those details/assumptions you are operating on in the changelog. --=20 Michal Hocko SUSE Labs