From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56656C43603 for ; Wed, 4 Dec 2019 14:42:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1BDB5205F4 for ; Wed, 4 Dec 2019 14:42:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BDB5205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BF5406B0AF8; Wed, 4 Dec 2019 09:42:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7E376B0B11; Wed, 4 Dec 2019 09:42:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6C486B0B13; Wed, 4 Dec 2019 09:42:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 8E49C6B0AF8 for ; Wed, 4 Dec 2019 09:42:52 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 3E4E4181AEF30 for ; Wed, 4 Dec 2019 14:42:52 +0000 (UTC) X-FDA: 76227725784.13.low97_533501e3f5606 X-HE-Tag: low97_533501e3f5606 X-Filterd-Recvd-Size: 5728 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Dec 2019 14:42:51 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id f4so5006948wmj.1 for ; Wed, 04 Dec 2019 06:42:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=fmkqNOaDxlFa9adJqpXSMGLRx9tYqe3bfVnOjKiJBj8=; b=FHJyjn2eALpfK9P71z9zed2Xc73EwvXpG5S2vBX8aGbqnEopa86K5WfGTzfWpKfwX5 rGcoPbhTNULuTqyrNOKXDa3Jv67wG2s+l2OiQQB6+a0NoOZP4szO2HI9FPLKSyCzlc45 ndb+BmDkwRllJ7bPnARm/HLkBY7ktbh3Zxp4nf9qdSlmoFZqJjF2c7g9OEz5d6QmLEL6 WsV9AHSSx7PwilXboco2ZYB+21k3XE8VNHuJWyqigsYZNLeENs2qcXTspvqUNDGVJcko 6eYOf7jNoOn0G/tsw0sZvuQoq6fY8jDZXZf/ijXLtvl+7EfQqrNCZsvjkUnqnqi/4tmd TO3A== X-Gm-Message-State: APjAAAUjqtDwv7f2YEmUSf2ItlGbs+X15fUW96tzICCKvnyQgsl6cZlE 8P6y1daNUvA0V+pTWYD1KYs= X-Google-Smtp-Source: APXvYqwSz66IR1bxVLLt9RZ38byrmQYX+FmrPmMpaXVz8Iv/tsYjvmFVCkFgMd/eEe+TtTuCDncVdA== X-Received: by 2002:a1c:9958:: with SMTP id b85mr33323811wme.63.1575470570528; Wed, 04 Dec 2019 06:42:50 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id e16sm6724403wme.35.2019.12.04.06.42.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 06:42:49 -0800 (PST) Date: Wed, 4 Dec 2019 15:42:48 +0100 From: Michal Hocko To: Thomas =?iso-8859-1?Q?Hellstr=F6m_=28VMware=29?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pv-drivers@vmware.com, linux-graphics-maintainer@vmware.com, Thomas Hellstrom , Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Ralph Campbell , =?iso-8859-1?B?Suly9G1l?= Glisse , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH v2 2/2] drm/ttm: Fix vm page protection handling Message-ID: <20191204144248.GK25242@dhcp22.suse.cz> References: <20191203104853.4378-1-thomas_os@shipmail.org> <20191203104853.4378-3-thomas_os@shipmail.org> <20191204135219.GH25242@dhcp22.suse.cz> <20191204143521.GJ25242@dhcp22.suse.cz> <5c2658b6-b5ec-5747-c360-fada54d759ed@shipmail.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <5c2658b6-b5ec-5747-c360-fada54d759ed@shipmail.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 04-12-19 15:36:58, Thomas Hellstr=F6m (VMware) wrote: > On 12/4/19 3:35 PM, Michal Hocko wrote: > > On Wed 04-12-19 15:16:09, Thomas Hellstr=F6m (VMware) wrote: > > > On 12/4/19 2:52 PM, Michal Hocko wrote: > > > > On Tue 03-12-19 11:48:53, Thomas Hellstr=F6m (VMware) wrote: > > > > > From: Thomas Hellstrom > > > > >=20 > > > > > TTM graphics buffer objects may, transparently to user-space, = move > > > > > between IO and system memory. When that happens, all PTEs point= ing to the > > > > > old location are zapped before the move and then faulted in aga= in if > > > > > needed. When that happens, the page protection caching mode- an= d > > > > > encryption bits may change and be different from those of > > > > > struct vm_area_struct::vm_page_prot. > > > > >=20 > > > > > We were using an ugly hack to set the page protection correctly= . > > > > > Fix that and instead use vmf_insert_mixed_prot() and / or > > > > > vmf_insert_pfn_prot(). > > > > > Also get the default page protection from > > > > > struct vm_area_struct::vm_page_prot rather than using vm_get_pa= ge_prot(). > > > > > This way we catch modifications done by the vm system for drive= rs that > > > > > want write-notification. > > > > So essentially this should have any new side effect on functional= ity it > > > > is just making a hacky/ugly code less so? > > > Functionality is unchanged. The use of a on-stack vma copy was seve= rely > > > frowned upon in an earlier thread, which also points to another sim= ilar > > > example using vmf_insert_pfn_prot(). > > >=20 > > > https://lore.kernel.org/lkml/20190905103541.4161-2-thomas_os@shipma= il.org/ > > >=20 > > > > In other words what are the > > > > consequences of having page protection inconsistent from vma's? > > > During the years, it looks like the caching- and encryption flags o= f > > > vma::vm_page_prot have been largely removed from usage. From what I= can > > > tell, there are no more places left that can affect TTM. We discuss= ed > > > __split_huge_pmd_locked() towards the end of that thread, but that = doesn't > > > affect TTM even with huge page-table entries. > > Please state all those details/assumptions you are operating on in th= e > > changelog. >=20 > Thanks. I'll update the patchset and add that. And thinking about that this also begs for a comment in the code to explain that some (which?) mappings might have a mismatch and the generic code have to be careful. Because as things stand now this seems to be really subtle and happen to work _now_ and might break in the futur= e. Or what does prevent a generic code to stumble over this discrepancy? --=20 Michal Hocko SUSE Labs