From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4999C43603 for ; Wed, 4 Dec 2019 15:32:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 665D8207DD for ; Wed, 4 Dec 2019 15:32:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 665D8207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 121946B0B41; Wed, 4 Dec 2019 10:32:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D2656B0B42; Wed, 4 Dec 2019 10:32:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F02AB6B0B43; Wed, 4 Dec 2019 10:32:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id DC0A86B0B41 for ; Wed, 4 Dec 2019 10:32:28 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 9270682D6B72 for ; Wed, 4 Dec 2019 15:32:28 +0000 (UTC) X-FDA: 76227850776.13.shop91_4fc5ab596e523 X-HE-Tag: shop91_4fc5ab596e523 X-Filterd-Recvd-Size: 3325 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Dec 2019 15:32:28 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id u18so148867wmc.3 for ; Wed, 04 Dec 2019 07:32:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fqpdfGJVxXCTd1ysYnxGhEaU7ov9/g/+UiQFsLmwatE=; b=Zpsw+/mrlsRs1uMYxtkGcD+QyJ19JPQ5q8rZyab4TM8b2F+2FfJWXfphbgvhp++sV8 48tpZQSZaGfoZ987OnTnXvzATUuvduL4w5Z4cKNNfPfkRSuryfHyiKC4JWWnFNX/aTnS sZcWzhJuUYUWXgtu8v3Dyns773ndbzUYsdKQlgfM6cGehAj10Tmt7AmtBUDwJHEMY+8K ma0NRKArRPVThMXqJ2QPAAwlY8avYRvSE6w0Q0Ocz0Rbl8KvySf/Tmk0KmDvMBf/MWck XO7a6iTVu1FEfeGrw8krpt6hgv6TFuYw/mE6cAwaNSPxvXkcKdi8W1443Ev7dvMxGAiB yINA== X-Gm-Message-State: APjAAAW0YNNgiZeYrVmtJbEU4noGD9xMOxbG3xgvd3tNNlPNd5ggJ1xk kP9FgGHQ9FsvcZX6OyftAn8= X-Google-Smtp-Source: APXvYqwn/WBB/hzGKanp+10p5bs6mE9YPi314bhT+wgpY0uHtHl9inmjfYZyNG1dLol7J+sZ06AyBg== X-Received: by 2002:a7b:c7cc:: with SMTP id z12mr140509wmk.115.1575473546961; Wed, 04 Dec 2019 07:32:26 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id n12sm7280468wmd.1.2019.12.04.07.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 07:32:25 -0800 (PST) Date: Wed, 4 Dec 2019 16:32:25 +0100 From: Michal Hocko To: Christopher Lameter Cc: LKML , linux-mm@kvack.org Subject: Re: SLUB: purpose of sysfs events on cache creation/removal Message-ID: <20191204153225.GM25242@dhcp22.suse.cz> References: <20191126121901.GE20912@dhcp22.suse.cz> <20191126165420.GL20912@dhcp22.suse.cz> <20191127162400.GT20912@dhcp22.suse.cz> <20191127174317.GD26807@dhcp22.suse.cz> <20191204132812.GF25242@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 04-12-19 15:25:43, Cristopher Lameter wrote: > On Wed, 4 Dec 2019, Michal Hocko wrote: > > > > > Just drop the events may be best. Then we know if someone is using it. > > > > > > I would be worried that a lack of events might be surprising and a > > > potential userspace wouldn't know that something has changed. > > > > It would be great to land with some decision here. > > Drop the events. These are internal kernel structures and supporting > notifiers to userspace is a bit unusual. As I've said I believe it is quite risky. But if you as a maintainer believe this is the right thing to do I will not object. Care to send a patch? -- Michal Hocko SUSE Labs