From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B31C43603 for ; Wed, 4 Dec 2019 15:59:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A79D2077B for ; Wed, 4 Dec 2019 15:59:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="JXM+kNuk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A79D2077B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 46A056B0B64; Wed, 4 Dec 2019 10:59:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 41C526B0B65; Wed, 4 Dec 2019 10:59:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30ABC6B0B66; Wed, 4 Dec 2019 10:59:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 05CA96B0B64 for ; Wed, 4 Dec 2019 10:59:51 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id C467C820757D for ; Wed, 4 Dec 2019 15:59:50 +0000 (UTC) X-FDA: 76227919740.09.horn63_1bb4a7a238127 X-HE-Tag: horn63_1bb4a7a238127 X-Filterd-Recvd-Size: 6335 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Dec 2019 15:59:50 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id 5so260790qtz.1 for ; Wed, 04 Dec 2019 07:59:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=sFepLZ6OnMRK4naYG+XlGBDsSgO0TlfIvhlIxKEb6bM=; b=JXM+kNuk9RiCYtsIMlqMyIdJMHztdqZg6ijzEGxxBoF9lerD5P5KGUDjwUcMJS0S7r ibicDlEt4RLrqxI+O7W4Fz48t9BPVxX017AGcAGQG01oqX9fCcZEG39xiCQC6r4eV/Bx v2lI23dFHYdeB7kasjpnJaae4QVzJ38kW1H2Ofz0l15eyAMc9PwQHPEPu93Xr+TZa62N JnGTxELo82oUym1FdKtT03COXJW1ONpyYG1MjzugbDrF4LjG8qQuNtjB9Uj/70daOJA4 qKiCe94BG+2kgt24Q8XBeUCwiZNzydHzwQCCLMemYIBgDEG3TfjDN7J2zxLMZDn0uWX4 APpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sFepLZ6OnMRK4naYG+XlGBDsSgO0TlfIvhlIxKEb6bM=; b=rv49xEjtW2FvxCo4OtY5HPXrLU3tvGziJFpx+2BBuVBNCCFghAndmKp3xB40A24nUb TROi37uzunJSVAMDKA2vvv2BG2fr2qLIJ+uRanM5z3yq/ZFGq2lkU+B51/v1HfNTBoCX CF+xXZ7n9tnLxLfz7D2cSECDY+QVYrJfnhjZ/ginKCTiKzu6nulYTrLFcQF5ox8eX3uO rgxB5IzpVfxAtPUtHtx2Devm7kaDbuxlTqWcHpUKID265pZEoOTcADMjH4VwptVEmSJ9 WVoctmN3LTtWi1hEkrqUx0pFckrRHmRLd//KWINTYOmi2uNp0Xz5jXAQA+Wxk5lJKFa3 JRQA== X-Gm-Message-State: APjAAAWOhRyGK68BgQWqVEselPk5G7aoS6FGHIVpOvaAHohUQI9ZYiRN R2OYA5Suz28lw5fb2dr2Qhz0Ig== X-Google-Smtp-Source: APXvYqx1pQqGZR+fje1UxGEllxPX0PSwVlnKObHzQ1pC9MqOEi/b0A2MPL6Hl2FZSZSFPrAFQuyz6g== X-Received: by 2002:ac8:7557:: with SMTP id b23mr1062511qtr.38.1575475189752; Wed, 04 Dec 2019 07:59:49 -0800 (PST) Received: from localhost.localdomain (c-73-69-118-222.hsd1.nh.comcast.net. [73.69.118.222]) by smtp.gmail.com with ESMTPSA id w21sm4177585qth.17.2019.12.04.07.59.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 07:59:49 -0800 (PST) From: Pavel Tatashin To: pasha.tatashin@soleen.com, jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, james.morse@arm.com, vladimir.murzin@arm.com, matthias.bgg@gmail.com, bhsharma@redhat.com, linux-mm@kvack.org, mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com, tglx@linutronix.de Subject: [PATCH v8 06/25] arm64: hibernate: use get_safe_page directly Date: Wed, 4 Dec 2019 10:59:19 -0500 Message-Id: <20191204155938.2279686-7-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204155938.2279686-1-pasha.tatashin@soleen.com> References: <20191204155938.2279686-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: create_safe_exec_page() uses hibernate's allocator to create a set of pag= e table to map a single page that will contain the relocation code. Remove the allocator related arguments, and use get_safe_page directly, a= s it is done in other local functions in this file to simplify function prototype. Removing this function pointer makes it easier to refactor the code later= . Signed-off-by: Pavel Tatashin Reviewed-by: Matthias Brugger --- arch/arm64/kernel/hibernate.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/arch/arm64/kernel/hibernate.c b/arch/arm64/kernel/hibernate.= c index ef46ce66d7e8..34297716643f 100644 --- a/arch/arm64/kernel/hibernate.c +++ b/arch/arm64/kernel/hibernate.c @@ -196,9 +196,7 @@ EXPORT_SYMBOL(arch_hibernation_header_restore); */ static int create_safe_exec_page(void *src_start, size_t length, unsigned long dst_addr, - phys_addr_t *phys_dst_addr, - void *(*allocator)(gfp_t mask), - gfp_t mask) + phys_addr_t *phys_dst_addr) { int rc =3D 0; pgd_t *trans_pgd; @@ -206,7 +204,7 @@ static int create_safe_exec_page(void *src_start, siz= e_t length, pud_t *pudp; pmd_t *pmdp; pte_t *ptep; - unsigned long dst =3D (unsigned long)allocator(mask); + unsigned long dst =3D get_safe_page(GFP_ATOMIC); =20 if (!dst) { rc =3D -ENOMEM; @@ -216,7 +214,7 @@ static int create_safe_exec_page(void *src_start, siz= e_t length, memcpy((void *)dst, src_start, length); __flush_icache_range(dst, dst + length); =20 - trans_pgd =3D allocator(mask); + trans_pgd =3D (void *)get_safe_page(GFP_ATOMIC); if (!trans_pgd) { rc =3D -ENOMEM; goto out; @@ -224,7 +222,7 @@ static int create_safe_exec_page(void *src_start, siz= e_t length, =20 pgdp =3D pgd_offset_raw(trans_pgd, dst_addr); if (pgd_none(READ_ONCE(*pgdp))) { - pudp =3D allocator(mask); + pudp =3D (void *)get_safe_page(GFP_ATOMIC); if (!pudp) { rc =3D -ENOMEM; goto out; @@ -234,7 +232,7 @@ static int create_safe_exec_page(void *src_start, siz= e_t length, =20 pudp =3D pud_offset(pgdp, dst_addr); if (pud_none(READ_ONCE(*pudp))) { - pmdp =3D allocator(mask); + pmdp =3D (void *)get_safe_page(GFP_ATOMIC); if (!pmdp) { rc =3D -ENOMEM; goto out; @@ -244,7 +242,7 @@ static int create_safe_exec_page(void *src_start, siz= e_t length, =20 pmdp =3D pmd_offset(pudp, dst_addr); if (pmd_none(READ_ONCE(*pmdp))) { - ptep =3D allocator(mask); + ptep =3D (void *)get_safe_page(GFP_ATOMIC); if (!ptep) { rc =3D -ENOMEM; goto out; @@ -530,8 +528,7 @@ int swsusp_arch_resume(void) */ rc =3D create_safe_exec_page(__hibernate_exit_text_start, exit_size, (unsigned long)hibernate_exit, - &phys_hibernate_exit, - (void *)get_safe_page, GFP_ATOMIC); + &phys_hibernate_exit); if (rc) { pr_err("Failed to create safe executable page for hibernate_exit code.= \n"); goto out; --=20 2.24.0