From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1655AC43603 for ; Thu, 5 Dec 2019 09:43:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D52252464E for ; Thu, 5 Dec 2019 09:43:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D52252464E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A7A616B0F81; Thu, 5 Dec 2019 04:43:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A50EF6B0F83; Thu, 5 Dec 2019 04:43:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 997D96B0F84; Thu, 5 Dec 2019 04:43:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 8328F6B0F81 for ; Thu, 5 Dec 2019 04:43:45 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 261E7A77D for ; Thu, 5 Dec 2019 09:43:45 +0000 (UTC) X-FDA: 76230600810.07.frogs11_39ceeeeb5c30 X-HE-Tag: frogs11_39ceeeeb5c30 X-Filterd-Recvd-Size: 4227 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Dec 2019 09:43:44 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id a15so2624332wrf.9 for ; Thu, 05 Dec 2019 01:43:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x2NY4RsN9EIpsZSpxJClccspscZUZls+ET6N9cgE4kc=; b=B0nBT8zc9zuqm+KCKwLVAjok3jQCrTGjj7WU1QpRQ/7DnD3yKfuBHHtZLDXSpqxUaj 0AW52+jzredYRL9oqxnCYHVjwTJfrtJDMK4aHDJ/hwZ4l6rdXA9uTaapLfs2xPEfrFMY oDWf13DiWIiyCI5mizhFVOMY2S+2oenTTTus3CKGb/XLo0/w71uRvKo8Qj9Lw+D21LGO DJjK/fsjaT5QiW/4Ox5e4ykD9Gx1l4D4YhPgqJJxg61yov3QZ3Hm+TUfz8sfrLUBm7fm AtR0ZOGMlc3I0Fhex5LXiiNEdzsXn3Y5sWtg0qN8sLWPYPW82qsDjdRcbz99UPR5dizT 2gnw== X-Gm-Message-State: APjAAAVW31SkKXgOezsyCPYemktKK/rpzgfdus3nSPyIra+2XdXQcXG9 JYqnSSit8jjiCPwpAB3ksrk= X-Google-Smtp-Source: APXvYqwoTreIVWXx2AHtCZXbwx/4wKo9v1WDlJAhlsuvcN/CjfFVnQDFjX0eJwsccVPt4FeM07XHgg== X-Received: by 2002:adf:8041:: with SMTP id 59mr8603077wrk.257.1575539023465; Thu, 05 Dec 2019 01:43:43 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id 72sm12036760wrl.73.2019.12.05.01.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2019 01:43:42 -0800 (PST) Date: Thu, 5 Dec 2019 10:43:41 +0100 From: Michal Hocko To: Kirill Tkhai Cc: Yang Shi , hannes@cmpxchg.org, shakeelb@google.com, guro@fb.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: protect shrinker idr replace with CONFIG_MEMCG Message-ID: <20191205094341.GC28317@dhcp22.suse.cz> References: <1575486978-45249-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 05-12-19 11:23:28, Kirill Tkhai wrote: > On 04.12.2019 22:16, Yang Shi wrote: > > Since commit 0a432dcbeb32edcd211a5d8f7847d0da7642a8b4 ("mm: shrinker: > > make shrinker not depend on memcg kmem"), shrinkers' idr is protected by > > CONFIG_MEMCG instead of CONFIG_MEMCG_KMEM, so it makes no sense to > > protect shrinker idr replace with CONFIG_MEMCG_KMEM. > > > > Cc: Kirill Tkhai > > Cc: Johannes Weiner > > Cc: Michal Hocko > > Cc: Shakeel Butt > > Cc: Roman Gushchin > > Signed-off-by: Yang Shi > > It looks like that in CONFIG_SLOB case we do not even call some shrinkers > for subordinate mem cgroups (i.e., we don't call deferred_split_shrinker), > since they never become completely registered. > > Fixes: 0a432dcbeb32edcd211a5d8f7847d0da7642a8b4 ("mm: shrinker: make shrinker not depend on memcg kmem") I am confused. Why the Fixes tag? Nothing should be really broken with KMEM config guard right? This is a mere clean up AFAICS. > Reviewed-by: Kirill Tkhai > > > --- > > mm/vmscan.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index ee4eecc..e7f10c4 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -422,7 +422,7 @@ void register_shrinker_prepared(struct shrinker *shrinker) > > { > > down_write(&shrinker_rwsem); > > list_add_tail(&shrinker->list, &shrinker_list); > > -#ifdef CONFIG_MEMCG_KMEM > > +#ifdef CONFIG_MEMCG > > if (shrinker->flags & SHRINKER_MEMCG_AWARE) > > idr_replace(&shrinker_idr, shrinker, shrinker->id); > > #endif > > -- Michal Hocko SUSE Labs