From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81FF5C43603 for ; Thu, 5 Dec 2019 09:44:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E73B2464D for ; Thu, 5 Dec 2019 09:44:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E73B2464D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E23866B0F83; Thu, 5 Dec 2019 04:44:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD4086B0F84; Thu, 5 Dec 2019 04:44:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D10356B0F85; Thu, 5 Dec 2019 04:44:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id B91D96B0F83 for ; Thu, 5 Dec 2019 04:44:03 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 68A7D181AEF1E for ; Thu, 5 Dec 2019 09:44:03 +0000 (UTC) X-FDA: 76230601566.03.tramp84_644e86b41604 X-HE-Tag: tramp84_644e86b41604 X-Filterd-Recvd-Size: 3609 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Dec 2019 09:44:02 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id p9so2874647wmc.2 for ; Thu, 05 Dec 2019 01:44:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ka9sSILTxUVdAZQPC7DMhXhoTbQ0HVKj/V2oqIbOzkM=; b=K8YhSgqyrAovPwFWDydixOGbpmX7K2VebvCSDlX3cpHGuL8xug1csQ2oIXOfS1CXqI mVsZFTxTq5A1RNXvWMzAz7+/D+Smr6ereMHY0ilvHrByQiNahbV4EgE+IGip+0J19NWi hzsPjL8KWArpSn6Dl3e3Y6vaq1YLLpcKxJjZFDetidOeBF8dRuuTlYFw4XsPO56keBFE xGyjn2Oy77eiRnmIqgYc/VradQuL5KEGn4QnEhs+EeFAbPA5wFCGs6XAfzUPu3k0GY1y 4XXn+2p4hQ/vCstcZSz5xW13IwB8twm63rfENsk8IFlaWYaq7MSafVEWvNqSy+IURYRb oUug== X-Gm-Message-State: APjAAAX2vWY0BvD7OUwH3w9n+FhiGEDGLr4jD2SkAYtJRcdplf6+ywzZ 2HjzZgz9qYIoNvpdKurIFX8= X-Google-Smtp-Source: APXvYqwrUVRVMKUxJPaCjMUQVE33lai5Ld4BdGvSwiW8Dv1YhLMcEAPCLflbsdQVilqLtU64uKqn0Q== X-Received: by 2002:a1c:e007:: with SMTP id x7mr3938784wmg.3.1575539042064; Thu, 05 Dec 2019 01:44:02 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id x18sm11464223wrr.75.2019.12.05.01.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2019 01:44:01 -0800 (PST) Date: Thu, 5 Dec 2019 10:44:00 +0100 From: Michal Hocko To: Yang Shi Cc: ktkhai@virtuozzo.com, hannes@cmpxchg.org, shakeelb@google.com, guro@fb.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: protect shrinker idr replace with CONFIG_MEMCG Message-ID: <20191205094400.GD28317@dhcp22.suse.cz> References: <1575486978-45249-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1575486978-45249-1-git-send-email-yang.shi@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 05-12-19 03:16:18, Yang Shi wrote: > Since commit 0a432dcbeb32edcd211a5d8f7847d0da7642a8b4 ("mm: shrinker: > make shrinker not depend on memcg kmem"), shrinkers' idr is protected by > CONFIG_MEMCG instead of CONFIG_MEMCG_KMEM, so it makes no sense to > protect shrinker idr replace with CONFIG_MEMCG_KMEM. > > Cc: Kirill Tkhai > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Shakeel Butt > Cc: Roman Gushchin > Signed-off-by: Yang Shi Acked-by: Michal Hocko > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index ee4eecc..e7f10c4 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -422,7 +422,7 @@ void register_shrinker_prepared(struct shrinker *shrinker) > { > down_write(&shrinker_rwsem); > list_add_tail(&shrinker->list, &shrinker_list); > -#ifdef CONFIG_MEMCG_KMEM > +#ifdef CONFIG_MEMCG > if (shrinker->flags & SHRINKER_MEMCG_AWARE) > idr_replace(&shrinker_idr, shrinker, shrinker->id); > #endif > -- > 1.8.3.1 -- Michal Hocko SUSE Labs