From: Jerome Glisse <jglisse@redhat.com>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ralph Campbell <rcampbell@nvidia.com>,
David Airlie <airlied@linux.ie>,
"Kuehling, Felix" <Felix.Kuehling@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>, Christoph Hellwig <hch@lst.de>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [GIT PULL] Please pull hmm changes
Date: Thu, 5 Dec 2019 11:03:24 -0500 [thread overview]
Message-ID: <20191205160324.GB5819@redhat.com> (raw)
In-Reply-To: <20191203024206.GC5795@mellanox.com>
On Tue, Dec 03, 2019 at 02:42:12AM +0000, Jason Gunthorpe wrote:
> On Sat, Nov 30, 2019 at 10:23:31AM -0800, Linus Torvalds wrote:
> > On Sat, Nov 30, 2019 at 10:03 AM Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> > >
> > > I'll try to figure the code out, but my initial reaction was "yeah,
> > > not in my VM".
> >
> > Why is it ok to sometimes do
> >
> > WRITE_ONCE(mni->invalidate_seq, cur_seq);
> >
> > (to pair with the unlocked READ_ONCE), and sometimes then do
> >
> > mni->invalidate_seq = mmn_mm->invalidate_seq;
> >
> > My initial guess was that latter is only done at initialization time,
> > but at least in one case it's done *after* the mni has been added to
> > the mmn_mm (oh, how I despise those names - I can only repeat: WTF?).
>
> Yes, the only occurrences are in the notifier_insert, under the
> spinlock. The one case where it is out of the natural order was to
> make the manipulation of seq a bit saner, but in all cases since the
> spinlock is held there is no way for another thread to get the pointer
> to the 'mmu_interval_notifier *' to do the unlocked read.
>
> Regarding the ugly names.. Naming has been really hard here because
> currently everything is a 'mmu notifier' and the natural abberviations
> from there are crummy. Here is the basic summary:
>
> struct mmu_notifier_mm (ie the mm->mmu_notifier_mm)
> -> mmn_mm
> struct mm_struct
> -> mm
> struct mmu_notifier (ie the user subscription to the mm_struct)
> -> mn
> struct mmu_interval_notifier (the other kind of user subscription)
> -> mni
What about "interval" the context should already tell people
it is related to mmu notifier and thus a notifier. I would
just remove the notifier suffix, this would match the below
range.
> struct mmu_notifier_range (ie the args to invalidate_range)
> -> range
Yeah range as context should tell you it is related to mmu
notifier.
>
> I can send a patch to switch mmn_mm to mmu_notifier_mm, which is the
> only pre-existing name for this value. But IIRC, it is a somewhat ugly
> with long line wrapping. 'mni' is a pain, I have to reflect on that.
> (honesly, I dislike mmu_notififer_mm quite a lot too)
>
> I think it would be overall nicer with better names for the original
> structs. Perhaps:
>
> mmn_* - MMU notifier prefix
> mmn_state <- struct mmu_notifier_mm
> mmn_subscription (mmn_sub) <- struct mmu_notifier
> mmn_range_subscription (mmn_range_sub) <- struct mmu_interval_notifier
> mmn_invalidate_desc <- struct mmu_notifier_range
This looks good.
>
> At least this is how I describe them in my mind.. This is a lot of
> churn, and spreads through many drivers. This is why I kept the names
> as-is and we ended up with the also quite bad 'mmu_interval_notifier'
>
> Maybe just switch mmu_notifier_mm for mmn_state and leave the drivers
> alone?
>
> Anyone on the CC list have advice?
Maybe we can do a semantic patch to do convertion and then Linus
can easily apply the patch by just re-running the coccinelle.
Cheers,
Jérôme
next prev parent reply other threads:[~2019-12-05 16:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 20:42 [GIT PULL] Please pull hmm changes Jason Gunthorpe
2019-11-30 18:03 ` Linus Torvalds
2019-11-30 18:23 ` Linus Torvalds
2019-12-03 2:42 ` Jason Gunthorpe
2019-12-05 16:03 ` Jerome Glisse [this message]
2019-12-11 22:57 ` Jason Gunthorpe
2019-12-13 10:19 ` Daniel Vetter
2019-12-18 14:59 ` Jason Gunthorpe
2019-12-18 16:53 ` Linus Torvalds
2019-12-18 18:37 ` Jason Gunthorpe
2019-12-18 19:33 ` Linus Torvalds
2019-12-05 23:03 ` John Hubbard
2019-12-11 22:47 ` Jason Gunthorpe
2019-11-30 18:35 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2020-08-04 15:06 Jason Gunthorpe
2020-08-05 20:33 ` pr-tracker-bot
2020-06-01 18:25 Jason Gunthorpe
2020-06-02 22:20 ` pr-tracker-bot
2020-03-30 17:57 [GIT PULL] Please pull HMM changes Jason Gunthorpe
2020-03-30 19:54 ` Nathan Chancellor
2020-03-30 20:08 ` Jason Gunthorpe
2019-07-30 11:58 [GIT PULL] Please pull hmm changes Jason Gunthorpe
2019-07-30 20:40 ` pr-tracker-bot
2019-07-09 19:24 Jason Gunthorpe
2019-07-15 2:48 ` Linus Torvalds
2019-07-15 3:00 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205160324.GB5819@redhat.com \
--to=jglisse@redhat.com \
--cc=Alexander.Deucher@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dan.j.williams@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jgg@mellanox.com \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rcampbell@nvidia.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).