From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C13C3F68F for ; Mon, 9 Dec 2019 18:25:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A6D220836 for ; Mon, 9 Dec 2019 18:25:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZnGDGGKR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A6D220836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F3986B280D; Mon, 9 Dec 2019 13:25:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A39A6B280E; Mon, 9 Dec 2019 13:25:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E1426B280F; Mon, 9 Dec 2019 13:25:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 17D6E6B280D for ; Mon, 9 Dec 2019 13:25:53 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id BB528180AD817 for ; Mon, 9 Dec 2019 18:25:52 +0000 (UTC) X-FDA: 76246431744.20.sound27_8a983d7e90e17 X-HE-Tag: sound27_8a983d7e90e17 X-Filterd-Recvd-Size: 2392 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Dec 2019 18:25:52 +0000 (UTC) Received: from localhost (unknown [5.29.147.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6DDB2077B; Mon, 9 Dec 2019 18:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575915951; bh=0x24JbKtdKPgiAN8s6OzmJaIhlnMzm4HgL/VS3/HRF0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZnGDGGKR61nsPfye0idSv4CQ458wRafaZkQmQZCr4nXClHZRBL14FF5hzcL+Iwr+5 hgKqXB4UAbwN8iFUPw+yFGaciUZ6nXVQwOXuO2IkSomP69aIOFbEOljPCDWfbrHpqd RXE7T3sI5DbZKTd2gmfnMybXHlxuYQ7vJwugYwdw= Date: Mon, 9 Dec 2019 20:25:47 +0200 From: Leon Romanovsky To: John Hubbard Cc: Andrew Morton , Jason Gunthorpe , Christoph Hellwig , Ira Weiny , linux-rdma@vger.kernel.org, linux-mm@kvack.org, LKML , Christoph Hellwig , Jan Kara , Jason Gunthorpe Subject: Re: [PATCH v2 2/2] IB/umem: use get_user_pages_fast() to pin DMA pages Message-ID: <20191209182547.GD67461@unreal> References: <20191204213603.464373-1-jhubbard@nvidia.com> <20191204213603.464373-3-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191204213603.464373-3-jhubbard@nvidia.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 04, 2019 at 01:36:03PM -0800, John Hubbard wrote: > And get rid of the mmap_sem calls, as part of that. Note > that get_user_pages_fast() will, if necessary, fall back to > __gup_longterm_unlocked(), which takes the mmap_sem as needed. > > Reviewed-by: Christoph Hellwig > Reviewed-by: Jan Kara > Reviewed-by: Jason Gunthorpe > Reviewed-by: Ira Weiny > Signed-off-by: John Hubbard > --- > drivers/infiniband/core/umem.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky