From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 476D9C3F68F for ; Wed, 11 Dec 2019 01:31:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D72E208C3 for ; Wed, 11 Dec 2019 01:31:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0PE2HvuI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D72E208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 99F9D6B2F56; Tue, 10 Dec 2019 20:31:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9766F6B2F57; Tue, 10 Dec 2019 20:31:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B4266B2F58; Tue, 10 Dec 2019 20:31:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 75CB26B2F56 for ; Tue, 10 Dec 2019 20:31:16 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 37270181AC9CC for ; Wed, 11 Dec 2019 01:31:16 +0000 (UTC) X-FDA: 76251132552.08.cough38_7f72886d24148 X-HE-Tag: cough38_7f72886d24148 X-Filterd-Recvd-Size: 2058 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Dec 2019 01:31:15 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 90C61206D5; Wed, 11 Dec 2019 01:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576027875; bh=wnOl6p1K/SUEQXiY8Gpr2seeZ+i631yAH+xs0grtRy0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0PE2HvuI9LIwtOeysXUN1ImbZRJLb/XthDWqd7Fg+5tFfEnUZ5OwJQmAXJFJvLVyl gNqkavvXjrKRMzn98OZgTHmr5M7KYttwI86S5Vc6NrKn6NKm1d6RYBL95gAzwyByiG y3R52W39slW/aKnJDxwbm7FvsvpkxmbtHYFRCMT8= Date: Tue, 10 Dec 2019 17:31:14 -0800 From: Andrew Morton To: Christoph Hellwig Cc: Daniel Axtens , kasan-dev@googlegroups.com, linux-mm@kvack.org, aryabinin@virtuozzo.com, glider@google.com, linux-kernel@vger.kernel.org, dvyukov@google.com, daniel@iogearbox.net, cai@lca.pw Subject: Re: [PATCH 1/3] mm: add apply_to_existing_pages helper Message-Id: <20191210173114.31a6f3e868f94173de76f5cb@linux-foundation.org> In-Reply-To: <20191209073458.GA3852@infradead.org> References: <20191205140407.1874-1-dja@axtens.net> <20191206163853.cdeb5dc80a8622fb6323a8d2@linux-foundation.org> <20191209073458.GA3852@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 8 Dec 2019 23:34:58 -0800 Christoph Hellwig wrote: > Or a flags argument with descriptive flags to the existing function? > These magic bool arguments don't scale.. True. But it's easy enough to do s/bool create/enum mode/ in the future should the need arise. For now, the code is clearer.