From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FDAEC33CB1 for ; Tue, 14 Jan 2020 08:46:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 12630207FF for ; Tue, 14 Jan 2020 08:46:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12630207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 60DB98E0005; Tue, 14 Jan 2020 03:46:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 598268E0003; Tue, 14 Jan 2020 03:46:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 486A78E0005; Tue, 14 Jan 2020 03:46:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 347668E0003 for ; Tue, 14 Jan 2020 03:46:30 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id ECF1F180AD815 for ; Tue, 14 Jan 2020 08:46:29 +0000 (UTC) X-FDA: 76375608498.13.noise04_55bdbb6c44552 X-HE-Tag: noise04_55bdbb6c44552 X-Filterd-Recvd-Size: 4218 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jan 2020 08:46:29 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id p9so12765075wmc.2 for ; Tue, 14 Jan 2020 00:46:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=W4sOMNbgj5qkf3xviPjIEOVCKMCJjwhUOtvFqpo2C+o=; b=AEFHDUPaacUsoOmcjGsQC45dZvnxTVw7W2NAiyIDwtB2h3bTrEJBgDc9Q0SIgEiHbC glMixHG4H7Gu2OpQZUU84qcJavUAbZZa44Yf1+avQewu4SfciEgx8I+Niq84K6A+Tqlb A4jq1BV5qUed7HcpkyQO52kKA3rW3JisANvuAPhW7ziihlUELUeP6UYNFJSV2s5QWsFH Dpuh76tsHwFs3KZ0NnpZCDOwOb7Elj+48V8LfxRlv74l9VhrrWdTJFko2WTaC+5PEyxb nV5BIqHEaa2FU374uq8nrwg+6Cc8CLg6sYTg8uvReI1PM+48qekdJHFyZ13bLHAsQye3 oHOw== X-Gm-Message-State: APjAAAXiTACpMN0TF9W6bL/lvu9f6BLp8HSLZV6Xq+ijlI19kaP+EP/V UB70iUaaJORL/x0so9s4Nxw= X-Google-Smtp-Source: APXvYqx6yL78H6SGlCfpYTOvJTr2PIp4ccYSSWLY3ZZHoEL7zJ4CZbF0rxrsyD3IVZQizDlzMtG3Pw== X-Received: by 2002:a1c:80d4:: with SMTP id b203mr2317735wmd.102.1578991587970; Tue, 14 Jan 2020 00:46:27 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id f1sm18969095wru.6.2020.01.14.00.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2020 00:46:27 -0800 (PST) Date: Tue, 14 Jan 2020 09:46:26 +0100 From: Michal Hocko To: Vlastimil Babka Cc: Linus Torvalds , Andrew Morton , David Rientjes , Mel Gorman , "Kirill A . Shutemov" , Andrea Arcangeli , Linux-MM , mm-commits@vger.kernel.org Subject: Re: [patch 01/11] mm, thp: tweak reclaim/compaction effort of local-only and all-node allocations Message-ID: <20200114084626.GC19428@dhcp22.suse.cz> References: <20200113162831.f7d69e11e9e673c40005c9b0@linux-foundation.org> <20200114002904.h9bSo%akpm@linux-foundation.org> <90d8ba5d-9462-bcfa-3e93-2ca53f1010ba@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90d8ba5d-9462-bcfa-3e93-2ca53f1010ba@suse.cz> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 14-01-20 09:05:57, Vlastimil Babka wrote: > On 1/14/20 3:16 AM, Linus Torvalds wrote: > > On Mon, Jan 13, 2020 at 4:29 PM Andrew Morton wrote: > >> > >> From: Vlastimil Babka > >> Subject: mm, thp: tweak reclaim/compaction effort of local-only and all-node allocations > > > > I absolutely _detest_ how we've had this pattern of trying to change > > the THP logic in a late -rc game. > > > > Considering how unsuccessful some of the earlier attempts have been, > > late -rc kernels really are *not* the time to make changes like this. > > Agreed, myself would have been much more comfortable in rc1. Yeah I do agree. The patch is a result of a regression I have reported back in early October (http://lkml.kernel.org/r/20191001083743.GC15624@dhcp22.suse.cz). The workload is quite trivial albeit artificial which doesn't make it super urgent. Still something to have addressed though. It has been mostly ignored for quite some time until Vlastimil came with the patch which improved the situation while not causing any other obvious problems (http://lkml.kernel.org/r/20191029151549.GO31513@dhcp22.suse.cz). It has been sitting in the mmotm tree since Oct 29 and in linux-next around a similar time without any reports. 5.5-rc1 (Dec 8) would have been a good time to target but I understand that a more time in linux-next wouldn't hurt and targeting 5.6-rc1 should be sufficient. -- Michal Hocko SUSE Labs